From: Bob Pearson <rpearsonhpe@gmail.com>
To: jgg@nvidia.com, leon@kernel.org, zyjzyj2000@gmail.com,
linux-rdma@vger.kernel.org
Cc: Bob Pearson <rpearsonhpe@gmail.com>
Subject: [PATCH for-next v2 14/18] RDMA/rxe: Extend rxe_init_req_packet() for frags
Date: Mon, 31 Oct 2022 15:28:03 -0500 [thread overview]
Message-ID: <20221031202805.19138-14-rpearsonhpe@gmail.com> (raw)
In-Reply-To: <20221031202805.19138-1-rpearsonhpe@gmail.com>
Add code to rxe_build_req_packet() to allocate space for the
pad and icrc if the skb is fragmented.
This is in preparation for supporting fragmented skbs.
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
---
drivers/infiniband/sw/rxe/rxe_loc.h | 9 +++-
drivers/infiniband/sw/rxe/rxe_req.c | 74 ++++++++++++++++++++++++-----
2 files changed, 71 insertions(+), 12 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rxe/rxe_loc.h
index 12fd5811cd79..cab6acad7a83 100644
--- a/drivers/infiniband/sw/rxe/rxe_loc.h
+++ b/drivers/infiniband/sw/rxe/rxe_loc.h
@@ -179,8 +179,15 @@ void rxe_srq_cleanup(struct rxe_pool_elem *elem);
void rxe_dealloc(struct ib_device *ib_dev);
-int rxe_completer(void *arg);
+/* rxe_req.c */
+int rxe_prepare_pad_icrc(struct rxe_pkt_info *pkt, struct sk_buff *skb,
+ int payload, bool frag);
int rxe_requester(void *arg);
+
+/* rxe_comp.c */
+int rxe_completer(void *arg);
+
+/* rxe_resp.c */
int rxe_responder(void *arg);
/* rxe_icrc.c */
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 71a65f2a5d6d..984e3e957aef 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -438,27 +438,79 @@ static void rxe_init_roce_hdrs(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
}
static int rxe_init_payload(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
- struct rxe_pkt_info *pkt, u32 payload,
- struct sk_buff *skb)
+ struct rxe_pkt_info *pkt, int pad, u32 payload,
+ struct sk_buff *skb, bool frag)
{
+ int len = skb_tailroom(skb);
+ int tot_len = payload + pad + RXE_ICRC_SIZE;
+ int access = 0;
int skb_offset = 0;
+ int op;
+ void *addr;
void *data;
int err = 0;
if (wqe->wr.send_flags & IB_SEND_INLINE) {
+ if (WARN_ON(frag))
+ return -EINVAL;
+ if (len < tot_len)
+ return -EINVAL;
data = &wqe->dma.inline_data[wqe->dma.sge_offset];
memcpy(payload_addr(pkt), data, payload);
wqe->dma.resid -= payload;
wqe->dma.sge_offset += payload;
} else {
- err = rxe_copy_dma_data(skb, qp->pd, 0, &wqe->dma,
- payload_addr(pkt), skb_offset,
- payload, RXE_COPY_FROM_MR);
+ op = frag ? RXE_FRAG_FROM_MR : RXE_COPY_FROM_MR;
+ addr = frag ? NULL : payload_addr(pkt);
+ err = rxe_copy_dma_data(skb, qp->pd, access, &wqe->dma,
+ addr, skb_offset, payload, op);
}
return err;
}
+/**
+ * rxe_prepare_pad_icrc() - Alloc space if fragmented and init pad and icrc
+ * @pkt: packet info
+ * @skb: packet buffer
+ * @payload: roce payload
+ * @frag: true if skb is fragmented
+ *
+ * Returns: 0 on success else an error
+ */
+int rxe_prepare_pad_icrc(struct rxe_pkt_info *pkt, struct sk_buff *skb,
+ int payload, bool frag)
+{
+ struct rxe_phys_buf dmabuf;
+ size_t offset;
+ u64 iova;
+ u8 *addr;
+ int err = 0;
+ int pad = (-payload) & 0x3;
+
+ if (frag) {
+ /* allocate bytes at the end of the skb linear buffer
+ * and build a frag pointing at it
+ */
+ WARN_ON((skb->end - skb->tail) < 8);
+ addr = skb_end_pointer(skb) - RXE_ICRC_SIZE - pad;
+ iova = (uintptr_t)addr;
+ dmabuf.addr = iova & PAGE_MASK;
+ offset = iova & ~PAGE_MASK;
+ err = rxe_add_frag(skb, &dmabuf, pad + RXE_ICRC_SIZE, offset);
+ if (err)
+ goto err;
+ } else {
+ addr = payload_addr(pkt) + payload;
+ }
+
+ /* init pad and icrc to zero */
+ memset(addr, 0, pad + RXE_ICRC_SIZE);
+
+err:
+ return err;
+}
+
static struct sk_buff *rxe_init_req_packet(struct rxe_qp *qp,
struct rxe_send_wqe *wqe,
int opcode, u32 payload,
@@ -468,9 +520,9 @@ static struct sk_buff *rxe_init_req_packet(struct rxe_qp *qp,
struct sk_buff *skb = NULL;
struct rxe_av *av;
struct rxe_ah *ah = NULL;
- void *padp;
int pad;
int err = -EINVAL;
+ bool frag = false;
pkt->rxe = rxe;
pkt->opcode = opcode;
@@ -498,15 +550,15 @@ static struct sk_buff *rxe_init_req_packet(struct rxe_qp *qp,
rxe_init_roce_hdrs(qp, wqe, pkt, pad);
if (pkt->mask & RXE_WRITE_OR_SEND_MASK) {
- err = rxe_init_payload(qp, wqe, pkt, payload, skb);
+ err = rxe_init_payload(qp, wqe, pkt, pad, payload, skb, frag);
if (err)
goto err_out;
}
- if (pad) {
- padp = payload_addr(pkt) + payload;
- memset(padp, 0, pad);
- }
+ /* handle pad and icrc */
+ err = rxe_prepare_pad_icrc(pkt, skb, payload, frag);
+ if (err)
+ goto err_out;
/* IP and UDP network headers */
err = rxe_prepare(av, pkt, skb);
--
2.34.1
next prev parent reply other threads:[~2022-10-31 20:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 20:27 [PATCH for-next v2 01/18] RDMA/rxe: Isolate code to fill request roce headers Bob Pearson
2022-10-31 20:27 ` [PATCH for-next v2 02/18] RDMA/rxe: Isolate request payload code in a subroutine Bob Pearson
2022-10-31 20:27 ` [PATCH for-next v2 03/18] RDMA/rxe: Remove paylen parameter from rxe_init_packet Bob Pearson
2022-10-31 20:27 ` [PATCH for-next v2 04/18] RDMA/rxe: Isolate code to build request packet Bob Pearson
2022-10-31 20:27 ` [PATCH for-next v2 05/18] RDMA/rxe: Add sg fragment ops Bob Pearson
2022-11-24 19:05 ` Jason Gunthorpe
2022-10-31 20:27 ` [PATCH for-next v2 06/18] RDMA/rxe: Add rxe_add_frag() to rxe_mr.c Bob Pearson
2022-11-24 19:10 ` Jason Gunthorpe
2022-11-30 20:53 ` Bob Pearson
2022-11-30 23:36 ` Jason Gunthorpe
2022-12-01 0:16 ` Bob Pearson
2022-12-01 0:20 ` Jason Gunthorpe
2022-12-01 0:36 ` Bob Pearson
2022-12-01 0:41 ` Jason Gunthorpe
2022-12-01 5:05 ` Bob Pearson
2022-12-01 12:51 ` Jason Gunthorpe
2022-12-01 15:04 ` Bob Pearson
2022-12-01 15:16 ` Bob Pearson
2022-12-01 15:38 ` Bob Pearson
2022-12-01 15:39 ` Jason Gunthorpe
2022-12-01 17:11 ` Bob Pearson
2022-12-01 18:00 ` Jason Gunthorpe
2022-10-31 20:27 ` [PATCH for-next v2 07/18] RDMA/rxe: Add routine to compute the number of frags Bob Pearson
2022-11-24 19:15 ` Jason Gunthorpe
2022-10-31 20:27 ` [PATCH for-next v2 08/18] RDMA/rxe: Extend rxe_mr_copy to support skb frags Bob Pearson
2022-10-31 20:27 ` [PATCH for-next v2 09/18] RDMA/rxe: Add routine to compute number of frags for dma Bob Pearson
2022-11-24 19:16 ` Jason Gunthorpe
2022-10-31 20:27 ` [PATCH for-next v2 10/18] RDMA/rxe: Extend copy_data to support skb frags Bob Pearson
2022-10-31 20:28 ` [PATCH for-next v2 11/18] RDMA/rxe: Replace rxe by qp as a parameter Bob Pearson
2022-10-31 20:28 ` [PATCH for-next v2 12/18] RDMA/rxe: Extend rxe_init_packet() to support frags Bob Pearson
2022-10-31 20:28 ` [PATCH for-next v2 13/18] RDMA/rxe: Extend rxe_icrc.c " Bob Pearson
2022-10-31 20:28 ` Bob Pearson [this message]
2022-10-31 20:28 ` [PATCH for-next v2 15/18] RDMA/rxe: Extend response packets for frags Bob Pearson
2022-10-31 20:28 ` [PATCH for-next v2 16/18] RDMA/rxe: Extend send/write_data_in() " Bob Pearson
2022-10-31 20:28 ` [PATCH for-next v2 17/18] RDMA/rxe: Extend do_read() in rxe_comp,c " Bob Pearson
2022-10-31 20:28 ` [PATCH for-next v2 18/18] RDMA/rxe: Enable sg code in rxe Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031202805.19138-14-rpearsonhpe@gmail.com \
--to=rpearsonhpe@gmail.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox