linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] RDMA/mlx5: Coding style fix
@ 2023-02-20 12:21 Rohit Chavan
  2023-02-22  8:03 ` Leon Romanovsky
  0 siblings, 1 reply; 2+ messages in thread
From: Rohit Chavan @ 2023-02-20 12:21 UTC (permalink / raw)
  To: Leon Romanovsky, Jason Gunthorpe, linux-rdma, linux-kernel; +Cc: Rohit Chavan

Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
 drivers/infiniband/hw/mlx5/qp.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index cf953d23d18d..45c45e57bbb8 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2769,9 +2769,9 @@ static void process_vendor_flag(struct mlx5_ib_dev *dev, int *flags, int flag,
 	case MLX5_QP_FLAG_SCATTER_CQE:
 	case MLX5_QP_FLAG_ALLOW_SCATTER_CQE:
 		/*
-			 * We don't return error if these flags were provided,
-			 * and mlx5 doesn't have right capability.
-			 */
+		 * We don't return error if these flags were provided,
+		 * and mlx5 doesn't have right capability.
+		 */
 		*flags &= ~(MLX5_QP_FLAG_SCATTER_CQE |
 			    MLX5_QP_FLAG_ALLOW_SCATTER_CQE);
 		return;
@@ -5514,8 +5514,7 @@ int mlx5_ib_modify_wq(struct ib_wq *wq, struct ib_wq_attr *wq_attr,
 		if (wq_attr->flags_mask & IB_WQ_FLAGS_CVLAN_STRIPPING) {
 			if (!(MLX5_CAP_GEN(dev->mdev, eth_net_offloads) &&
 			      MLX5_CAP_ETH(dev->mdev, vlan_cap))) {
-				mlx5_ib_dbg(dev, "VLAN offloads are not "
-					    "supported\n");
+				mlx5_ib_dbg(dev, "VLAN offloads are not supported\n");
 				err = -EOPNOTSUPP;
 				goto out;
 			}
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] RDMA/mlx5: Coding style fix
  2023-02-20 12:21 [PATCH] RDMA/mlx5: Coding style fix Rohit Chavan
@ 2023-02-22  8:03 ` Leon Romanovsky
  0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2023-02-22  8:03 UTC (permalink / raw)
  To: Rohit Chavan; +Cc: Jason Gunthorpe, linux-rdma, linux-kernel

On Mon, Feb 20, 2023 at 05:51:16PM +0530, Rohit Chavan wrote:
> Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
> ---
>  drivers/infiniband/hw/mlx5/qp.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)


Please try to avoid empty commit messages.

And we are in merge window now, so new version of this patch will need
to wait till -rc1.

Thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-22  8:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 12:21 [PATCH] RDMA/mlx5: Coding style fix Rohit Chavan
2023-02-22  8:03 ` Leon Romanovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).