Re: [bug report] RDMA/rxe: Rewrite rxe_task.c

Dan Carpenter
2023-03-29T06:48:42Z

On Wed, Mar 29, 2023 at 09:27:26AM +0300, Dan Carpenter wrote:
> Hello Bob Pearson,
>
> The patch d94671632572: "RDMA/rxe: Rewrite rxe_task.c" from Mar 4,
> 2023, leads to the following Smatch static checker warning:
>
> drivers/infiniband/sw/rxe/rxe_task.c:24 __reserve_if_idle()
> warn: bitwise AND condition is false here
>
> drivers/infiniband/sw/rxe/rxe_task.c
> 20 static bool __reserve_if_idle(struct rxe_task *task)
> 21 {
> 22 WARN_ON(rxe_read(task->qp) <= 0);
> 23
> --> 24 if (task->tasklet.state & TASKLET_STATE_SCHED)
> ^^^^^^^^^^^^^^^^^^^
> This is zero. Should the check be == TASKLET_STATE_SCHED?
>

The next function as well.

drivers/infiniband/sw/rxe/rxe_task.c:49 __is_done() warn: bitwise AND condition is false here