From: Leon Romanovsky <leon@kernel.org>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Dan Carpenter <error27@gmail.com>,
linux-rdma@vger.kernel.org, Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next] RDMA/rxe: Properly check tasklet state
Date: Wed, 29 Mar 2023 22:17:35 +0300 [thread overview]
Message-ID: <20230329191735.GH831478@unreal> (raw)
In-Reply-To: <e74f86fa-7332-8503-0660-4568c730c5df@gmail.com>
On Wed, Mar 29, 2023 at 02:15:30PM -0500, Bob Pearson wrote:
> On 3/29/23 13:18, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > Fix the following smatch error:
> >
> > drivers/infiniband/sw/rxe/rxe_task.c:24 __reserve_if_idle()
> > warn: bitwise AND condition is false here
> >
> > Fixes: d94671632572 ("RDMA/rxe: Rewrite rxe_task.c")
> > Reported-by: Dan Carpenter <error27@gmail.com>
> > Link: https://lore.kernel.org/all/480b32b6-0f1c-4646-9ecc-e0760004cd24@kili.mountain
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> > drivers/infiniband/sw/rxe/rxe_task.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/infiniband/sw/rxe/rxe_task.c b/drivers/infiniband/sw/rxe/rxe_task.c
> > index fea9a517c8d9..48c89987137c 100644
> > --- a/drivers/infiniband/sw/rxe/rxe_task.c
> > +++ b/drivers/infiniband/sw/rxe/rxe_task.c
> > @@ -21,7 +21,7 @@ static bool __reserve_if_idle(struct rxe_task *task)
> > {
> > WARN_ON(rxe_read(task->qp) <= 0);
> >
> > - if (task->tasklet.state & TASKLET_STATE_SCHED)
> > + if (task->tasklet.state == TASKLET_STATE_SCHED)
> > return false;
> >
> > if (task->state == TASK_STATE_IDLE) {
> > @@ -46,7 +46,7 @@ static bool __reserve_if_idle(struct rxe_task *task)
> > */
> > static bool __is_done(struct rxe_task *task)
> > {
> > - if (task->tasklet.state & TASKLET_STATE_SCHED)
> > + if (task->tasklet.state == TASKLET_STATE_SCHED)
> > return false;
> >
> > if (task->state == TASK_STATE_IDLE ||
>
> Leon, This is not correct either. I am about to fix this. -- Bob
Sure, no problem.
Thanks
prev parent reply other threads:[~2023-03-29 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 18:18 [PATCH rdma-next] RDMA/rxe: Properly check tasklet state Leon Romanovsky
2023-03-29 19:15 ` Bob Pearson
2023-03-29 19:17 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329191735.GH831478@unreal \
--to=leon@kernel.org \
--cc=error27@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox