From: Zhu Yanjun <yanjun.zhu@intel.com>
To: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org,
linux-rdma@vger.kernel.org
Cc: Zhu Yanjun <yanjun.zhu@linux.dev>
Subject: [PATCH 1/1] RDMA/rxe: Add function name to the logs
Date: Mon, 10 Apr 2023 18:21:05 +0800 [thread overview]
Message-ID: <20230410102105.1084967-1-yanjun.zhu@intel.com> (raw)
From: Zhu Yanjun <yanjun.zhu@linux.dev>
Add the function names to the pr_ logs. As such, if some bugs occur,
with function names, it is easy to locate the bugs.
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/sw/rxe/rxe.h | 2 +-
drivers/infiniband/sw/rxe/rxe_queue.h | 12 ++++--------
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe.h b/drivers/infiniband/sw/rxe/rxe.h
index 2415f3704f57..43742d2f32de 100644
--- a/drivers/infiniband/sw/rxe/rxe.h
+++ b/drivers/infiniband/sw/rxe/rxe.h
@@ -10,7 +10,7 @@
#ifdef pr_fmt
#undef pr_fmt
#endif
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__
#include <linux/skbuff.h>
diff --git a/drivers/infiniband/sw/rxe/rxe_queue.h b/drivers/infiniband/sw/rxe/rxe_queue.h
index c711cb98b949..5d6e17b00e60 100644
--- a/drivers/infiniband/sw/rxe/rxe_queue.h
+++ b/drivers/infiniband/sw/rxe/rxe_queue.h
@@ -185,8 +185,7 @@ static inline void queue_advance_producer(struct rxe_queue *q,
case QUEUE_TYPE_FROM_CLIENT:
/* used by rxe, client owns the index */
if (WARN_ON(1))
- pr_warn("%s: attempt to advance client index\n",
- __func__);
+ pr_warn("attempt to advance client index\n");
break;
case QUEUE_TYPE_TO_CLIENT:
/* used by rxe which owns the index */
@@ -206,8 +205,7 @@ static inline void queue_advance_producer(struct rxe_queue *q,
case QUEUE_TYPE_TO_ULP:
/* used by ulp, rxe owns the index */
if (WARN_ON(1))
- pr_warn("%s: attempt to advance driver index\n",
- __func__);
+ pr_warn("attempt to advance driver index\n");
break;
}
}
@@ -228,14 +226,12 @@ static inline void queue_advance_consumer(struct rxe_queue *q,
case QUEUE_TYPE_TO_CLIENT:
/* used by rxe, client owns the index */
if (WARN_ON(1))
- pr_warn("%s: attempt to advance client index\n",
- __func__);
+ pr_warn("attempt to advance client index\n");
break;
case QUEUE_TYPE_FROM_ULP:
/* used by ulp, rxe owns the index */
if (WARN_ON(1))
- pr_warn("%s: attempt to advance driver index\n",
- __func__);
+ pr_warn("attempt to advance driver index\n");
break;
case QUEUE_TYPE_TO_ULP:
/* used by ulp which owns the index */
--
2.27.0
next reply other threads:[~2023-04-10 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 10:21 Zhu Yanjun [this message]
2023-04-16 14:43 ` [PATCH 1/1] RDMA/rxe: Add function name to the logs Zhu Yanjun
2023-04-18 8:08 ` Leon Romanovsky
2023-04-18 10:36 ` Zhu Yanjun
-- strict thread matches above, loose matches on Subject: below --
2023-04-18 12:26 Zhu Yanjun
2023-04-21 15:27 ` Jason Gunthorpe
2023-04-21 15:51 ` Zhu Yanjun
2023-04-28 13:24 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230410102105.1084967-1-yanjun.zhu@intel.com \
--to=yanjun.zhu@intel.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox