Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Zhu Yanjun <yanjun.zhu@linux.dev>
Cc: Zhu Yanjun <yanjun.zhu@intel.com>,
	zyjzyj2000@gmail.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
	syzbot+cfcc1a3c85be15a40cba@syzkaller.appspotmail.com
Subject: Re: [PATCHv2 1/1] RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task"
Date: Thu, 13 Apr 2023 11:23:16 +0300	[thread overview]
Message-ID: <20230413082316.GC17993@unreal> (raw)
In-Reply-To: <29d0ab8c-1ea4-bbce-120b-82c390b56a6f@linux.dev>

On Mon, Apr 10, 2023 at 11:08:15PM +0800, Zhu Yanjun wrote:
> 在 2023/4/4 14:38, Zhu Yanjun 写道:
> > From: Zhu Yanjun <yanjun.zhu@linux.dev>
> > 
> > In the function rxe_create_qp(), rxe_qp_from_init() is called to
> > initialize qp, internally things like rxe_init_task are not setup until
> > rxe_qp_init_req().
> > 
> > If an error occures before this point then the unwind will call
> > rxe_cleanup() and eventually to rxe_qp_do_cleanup()/rxe_cleanup_task()
> > which will oops when trying to access the uninitialized spinlock.
> > 
> > If rxe_init_task is not executed, rxe_cleanup_task will not be called.
> > 
> > Reported-by: syzbot+cfcc1a3c85be15a40cba@syzkaller.appspotmail.com
> > Link: https://syzkaller.appspot.com/bug?id=fd85757b74b3eb59f904138486f755f71e090df8
> > 
> > Fixes: 8700e3e7c485 ("Soft RoCE driver")
> > Fixes: 2d4b21e0a291 ("IB/rxe: Prevent from completer to operate on non valid QP")
> > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> > ---
> > V1 -> V2: Remove memset functions;
> 
> Gently ping

It doesn't apply to rdma-next.

Thanks

  reply	other threads:[~2023-04-13  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04  6:38 [PATCHv2 1/1] RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task" Zhu Yanjun
2023-04-10 15:08 ` Zhu Yanjun
2023-04-13  8:23   ` Leon Romanovsky [this message]
2023-04-13 10:01     ` Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413082316.GC17993@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=syzbot+cfcc1a3c85be15a40cba@syzkaller.appspotmail.com \
    --cc=yanjun.zhu@intel.com \
    --cc=yanjun.zhu@linux.dev \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox