Re: [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU

Jakub Kicinski
2023-04-15T02:04:57Z

On Wed, 12 Apr 2023 14:16:01 -0700 Haiyang Zhang wrote:
> +/* Allocate frag for rx buffer, and save the old buf */
> +static void mana_refill_rxoob(struct device *dev, struct mana_rxq *rxq,

The fill function is spelled with a _ between rx and oob,
please be consistent.

> + struct mana_recv_buf_oob *rxoob, void **old_buf)
> +{
> + dma_addr_t da;
> + void *va;
> +
> + va = mana_get_rxfrag(rxq, dev, &da, true);
> +

no empty lines between function call and error check.
Please fix this in all the code this patch set is touching.

> + if (!va)
> + return;