From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F96C7EE22 for ; Wed, 10 May 2023 10:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236086AbjEJKVG (ORCPT ); Wed, 10 May 2023 06:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235752AbjEJKVF (ORCPT ); Wed, 10 May 2023 06:21:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34703213B for ; Wed, 10 May 2023 03:21:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84A4F63008 for ; Wed, 10 May 2023 10:21:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23E6CC433EF; Wed, 10 May 2023 10:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683714062; bh=PeThsWlr8cFpa/kNEF0zKl3ZNnMw52MreVRfRen/6OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MnPHJb+FU0iJr+0xfR09a/94ocM16Urg26MuwXqYCJk+bx84RlXJsSjFD6vE2xyw0 a8wH1IvttiRLaGysJh0FqFctcEAuRL4NaFd2t8FOLuGL+KOQXlPt22oZLTxZITJbTs Po3cQg4fw1VD/F2Jv9WBKlCijpXnQ/yUvQTHL6uzr6Sbt7780IM91wdsov/DcyFlKJ G7QlIZtE2Rwv7PPw5xJ03K7Vk8T2ETnkLfH9bcl6HaWKPgzIEQhhF5hdp+WAETmnzH njHt/nf4wtrKnGgfRUrzlvvt5guTMruxchz8Y9RuahnKSB8da3g0WBbM4lLoxXQzq4 IEpvFxgARdq9g== Date: Wed, 10 May 2023 13:20:58 +0300 From: Leon Romanovsky To: Animesh Kishore Cc: linux-rdma@vger.kernel.org, jgg@mellanox.com Subject: Re: [PATCH] verbs: Add RDMA write RC pingpong test Message-ID: <20230510102058.GR38143@unreal> References: <20230509095016.112453-1-animesh.kishore@gmail.com> <20230509133727.GJ38143@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, May 10, 2023 at 03:30:00PM +0530, Animesh Kishore wrote: > On Tue, May 9, 2023 at 7:07 PM Leon Romanovsky wrote: > > > > On Tue, May 09, 2023 at 12:50:16PM +0300, Animesh Kishore wrote: > > > - The test pingpongs data between server and client > > > instance using RC QPs with RDMA write BTH opcode. > > > - For RDMA write, there's no completion at responder. Hence, > > > we send a sideband ACK(using socket) from requester side > > > on completion. This indicates to responder that it has > > > received data. > > > > > > Check available test arguments and help: > > > ./build/bin/ibv_rc_wr_pingpong -h > > > > > > e.g. > > > Run server instance: > > > ./build/bin/ibv_rc_wr_pingpong -g 0 -d -c -s 8192 > > > > > > Run client instance: > > > ./build/bin/ibv_rc_wr_pingpong -g 0 -d -c -s 8192 > > > > > > Signed-off-by: Animesh Kishore > > > --- > > > debian/ibverbs-utils.install | 2 + > > > libibverbs/examples/CMakeLists.txt | 3 + > > > libibverbs/examples/rc_wr_pingpong.c | 782 +++++++++++++++++++++++++++ > > > libibverbs/man/CMakeLists.txt | 1 + > > > libibverbs/man/ibv_rc_wr_pingpong.1 | 63 +++ > > > 5 files changed, 851 insertions(+) > > > create mode 100644 libibverbs/examples/rc_wr_pingpong.c > > > create mode 100644 libibverbs/man/ibv_rc_wr_pingpong.1 > > > > Like I said in relevant PR https://github.com/linux-rdma/rdma-core/pull/1325#issuecomment-1531194836 > > This new ibv_rc_wr_pingpong is unlikely to be merged. > > > > Thanks > > Hi Leon, > > Do you suggest to wait for more comments or close the PR at once ? You need to find more people who think that such application must be included in rdma-core. > > I think it's helpful for new users for below reasons. > Helps demonstrate complete flow and API usages. Works as a reference > to build IBverbs production applications which are typically in C/C++. > > Also note, it's an overkill to extend existing example/rc_pingpong.c > (uses send/recv) to support RDMA write. It is unlikely to be accepted either. > > Thanks > Animesh