From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E37CC83005 for ; Wed, 7 Jun 2023 16:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231836AbjFGQTX (ORCPT ); Wed, 7 Jun 2023 12:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232727AbjFGQTQ (ORCPT ); Wed, 7 Jun 2023 12:19:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93C981702 for ; Wed, 7 Jun 2023 09:19:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 247F263C0F for ; Wed, 7 Jun 2023 16:19:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2F85C433EF; Wed, 7 Jun 2023 16:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686154751; bh=aQC2SIhgbGQP6vPMDcforICIRjbQ3XlpE3iaJwWJlxc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KEA1pDLkuWW0O8jeB4lN31JCEYHYGaOR1lTE4Cgtq0bHXrTh/Gdvs1u/xiQIcuZhh 72vNP3zkmrpwBSdn1d49fHwLZ5PwSXh26QbV3rkyMdcLyYlXd3lQjDP+h3/Yu448TC 0kJornPXmhJ5GARA9k3BkPz2UdPnF5FnQBkpoeAwYnQG52F3TPaPP9FO/oiTsELrx8 9v9Ie0wg+CYhGB5W4KWfVjH6EmZdO6ulEq4ayLJpk9UFvSrxB2Dv5wXphFjAJdFe8R w2SIo7uOw/iNK2xsllTZoRdah4c7sdXta8bVKp0BD9IKeqOIyoFNfI1jI93t8oQyX+ 8yUFUawqnIcng== Date: Wed, 7 Jun 2023 09:19:09 -0700 From: Jakub Kicinski To: Jason Gunthorpe Cc: Saeed Mahameed , "David S. Miller" , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, Jiri Pirko Subject: Re: [net-next 13/15] net/mlx5: Skip inline mode check after mlx5_eswitch_enable_locked() failure Message-ID: <20230607091909.321fc5d7@kernel.org> In-Reply-To: References: <20230606071219.483255-1-saeed@kernel.org> <20230606071219.483255-14-saeed@kernel.org> <20230606220117.0696be3e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, 7 Jun 2023 11:10:42 -0300 Jason Gunthorpe wrote: > On Tue, Jun 06, 2023 at 10:01:17PM -0700, Jakub Kicinski wrote: > > On Tue, 6 Jun 2023 00:12:17 -0700 Saeed Mahameed wrote: > > > Fixes: bffaa916588e ("net/mlx5: E-Switch, Add control for inline mode") > > > Fixes: 8c98ee77d911 ("net/mlx5e: E-Switch, Add extack messages to devlink callbacks") > > > > The combination of net-next and Fixes is always odd. > > Why? > > Either it's important enough to be a fix or its not important > > and can go to net-next... > > Generally I tell people to mark things as Fixes if it is a fix, > regardless of how small, minor or unimportant. Yes, exactly, we do the same, but also to send them all to net. > It helps backporters because they can suck in the original patch and > all the touchups then test that result. If people try to predict if it > is "important" or not they get it wrong quite often. > > Fixes is not supposed to mean "this is important" or "send this to > -rc" or "apply it to -stable" Agreed with the distinction that we consider every fix -rc worthy. We'll obviously apply our own judgment but submitter should send all fixes against net. > If it is really important add a 'cc: stable'. > > If it is sort of important then send it to the -rc tree. > > Otherwise dump it in the merge window. You just said that people can't predict the importance of their fixes and yet you draw categories. > But mark it with Fixes regardless Every subsystem can make their own rules. In netdev Fixes go to net.