From: Zhu Yanjun <yanjun.zhu@intel.com>
To: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org,
linux-rdma@vger.kernel.org, parav@nvidia.com, lehrer@gmail.com,
rpearsonhpe@gmail.com
Cc: Zhu Yanjun <yanjun.zhu@linux.dev>,
Rain River <rain.1986.08.12@gmail.com>
Subject: [PATCH v6 3/8] RDMA/nldev: Add dellink function pointer
Date: Fri, 23 Jun 2023 17:57:44 +0800 [thread overview]
Message-ID: <20230623095749.485873-4-yanjun.zhu@intel.com> (raw)
In-Reply-To: <20230623095749.485873-1-yanjun.zhu@intel.com>
From: Zhu Yanjun <yanjun.zhu@linux.dev>
The newlink function pointer is added. And the sock listening on port 4791
is added in the newlink function. So the dellink function is needed to
remove the sock.
Tested-by: Rain River <rain.1986.08.12@gmail.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/core/nldev.c | 6 ++++++
include/rdma/rdma_netlink.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
index d5d3e4f0de77..97a62685ed5b 100644
--- a/drivers/infiniband/core/nldev.c
+++ b/drivers/infiniband/core/nldev.c
@@ -1758,6 +1758,12 @@ static int nldev_dellink(struct sk_buff *skb, struct nlmsghdr *nlh,
return -EINVAL;
}
+ if (device->link_ops) {
+ err = device->link_ops->dellink(device);
+ if (err)
+ return err;
+ }
+
ib_unregister_device_and_put(device);
return 0;
}
diff --git a/include/rdma/rdma_netlink.h b/include/rdma/rdma_netlink.h
index c2a79aeee113..bf9df004061f 100644
--- a/include/rdma/rdma_netlink.h
+++ b/include/rdma/rdma_netlink.h
@@ -5,6 +5,7 @@
#include <linux/netlink.h>
#include <uapi/rdma/rdma_netlink.h>
+#include <rdma/ib_verbs.h>
enum {
RDMA_NLDEV_ATTR_EMPTY_STRING = 1,
@@ -114,6 +115,7 @@ struct rdma_link_ops {
struct list_head list;
const char *type;
int (*newlink)(const char *ibdev_name, struct net_device *ndev);
+ int (*dellink)(struct ib_device *dev);
};
void rdma_link_register(struct rdma_link_ops *ops);
--
2.27.0
next prev parent reply other threads:[~2023-06-23 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 9:57 [PATCH v6 0/8] Fix the problem that rxe can not work in net namespace Zhu Yanjun
2023-06-23 9:57 ` [PATCH v6 1/8] RDMA/rxe: Creating listening sock in newlink function Zhu Yanjun
2023-06-23 9:57 ` [PATCH v6 2/8] RDMA/rxe: Support more rdma links in init_net Zhu Yanjun
2023-06-23 9:57 ` Zhu Yanjun [this message]
2023-06-23 10:11 ` [PATCH v6 3/8] RDMA/nldev: Add dellink function pointer Bernard Metzler
2023-06-23 13:55 ` Zhu Yanjun
2023-06-23 9:57 ` [PATCH v6 4/8] RDMA/rxe: Implement dellink in rxe Zhu Yanjun
2023-06-23 9:57 ` [PATCH v6 5/8] RDMA/rxe: Replace global variable with sock lookup functions Zhu Yanjun
2023-06-23 9:57 ` [PATCH v6 6/8] RDMA/rxe: add the support of net namespace Zhu Yanjun
2023-06-23 9:57 ` [PATCH v6 7/8] RDMA/rxe: Add the support of net namespace notifier Zhu Yanjun
2023-06-23 9:57 ` [PATCH v6 8/8] RDMA/rxe: Replace l_sk6 with sk6 in net namespace Zhu Yanjun
2023-06-23 13:00 ` [PATCH v6 0/8] Fix the problem that rxe can not work " Bob Pearson
2023-06-23 23:39 ` Zhu Yanjun
2024-11-12 8:49 ` '[v6,0/8] Fix the problem that rxe can not work in net namespace' Cyclinder Kuo
2024-11-12 8:49 ` Cyclinder Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623095749.485873-4-yanjun.zhu@intel.com \
--to=yanjun.zhu@intel.com \
--cc=jgg@ziepe.ca \
--cc=lehrer@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=rain.1986.08.12@gmail.com \
--cc=rpearsonhpe@gmail.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox