From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC57DC0015E for ; Fri, 7 Jul 2023 10:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbjGGKv5 (ORCPT ); Fri, 7 Jul 2023 06:51:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232799AbjGGKvr (ORCPT ); Fri, 7 Jul 2023 06:51:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC341FEE; Fri, 7 Jul 2023 03:51:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39E9A618F4; Fri, 7 Jul 2023 10:51:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DABADC433C8; Fri, 7 Jul 2023 10:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688727090; bh=dMjQvPWxzVC76cHGIJsn2XnTQOoQzkZMZV+Gp6SjNoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DzXWq+TsLd9+UoSFGQPsmq3hgM4LcY9udSFATS9UWuXZiFNJWyB3yGhLH7RM4CS3l 9KnIQzdut1CSiROHnyHybMwykGtwNtpvZxhABiQgFqpj9OjaVHaGo2rnD77OuC49hV 1TRpdcEC8jDYEl6uSbrXQ3usPjzg2JnOKsHPoT34= Date: Fri, 7 Jul 2023 11:16:07 +0100 From: Greg KH To: Souradeep Chakrabarti Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com, sharmaajay@microsoft.com, leon@kernel.org, cai.huoqing@linux.dev, ssengar@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, stable@vger.kernel.org, schakrabarti@microsoft.com Subject: Re: [PATCH V2 net] net: mana: Configure hwc timeout from hardware Message-ID: <2023070734-skimming-snack-838c@gregkh> References: <1688723128-14878-1-git-send-email-schakrabarti@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1688723128-14878-1-git-send-email-schakrabarti@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Jul 07, 2023 at 02:45:28AM -0700, Souradeep Chakrabarti wrote: > At present hwc timeout value is a fixed value. > This patch sets the hwc timeout from the hardware. This really does not describe what is happening here. Please read the documentation for how to write a good changelog text. > > Signed-off-by: Souradeep Chakrabarti > --- > V1 -> V2: > * Added return check for mana_gd_query_hwc_timeout > * Removed dev_err from mana_gd_query_hwc_timeout This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.