From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E1DEB64DA for ; Tue, 18 Jul 2023 09:40:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231362AbjGRJkh (ORCPT ); Tue, 18 Jul 2023 05:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231458AbjGRJkg (ORCPT ); Tue, 18 Jul 2023 05:40:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D34FE55 for ; Tue, 18 Jul 2023 02:40:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32D976148E for ; Tue, 18 Jul 2023 09:40:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05904C433C7; Tue, 18 Jul 2023 09:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689673231; bh=UUG0pWqPOPAXabGgVF1Ytb5r7tDsGH9qe0aQKsrWsFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i4PJ6udNCcIVYHeykc15p6fZS8RD8Y1Z1ecz6Jd4wOkC/QKPuyF9jqOsEjZwK66CY iTtGRO7na4ZwmfJqcGykLoymZEOVT/hCd8MdgZ2MyzqdXFH/P/4ZurKF3G/tQf688p WJUrJRdYF0TF2csaxLn1ZiYir5shUBklUyj5OkHxE8A1oSmOEh1UfDzcQwFqY5Gqd/ hQB441iqPv8+jHiv9/aZuWxzHl0KrXQxXtJmBLGusSwaUC14S7TMZK7/v9yz96KRTi zomabcDsEJfNEz01t+YRE9hlunI72OkefP0pZwxhR8zcQQNxoCg3zaE/dzTbvmwmz7 hdd7Ne/3YHavw== Date: Tue, 18 Jul 2023 12:40:27 +0300 From: Leon Romanovsky To: Selvin Xavier , jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, michael.chan@broadcom.com Subject: Re: [PATCH for-next v2 0/7]RDMA/bnxt_re: Doorbell Drop Prevention Message-ID: <20230718094027.GB8808@unreal> References: <1689573194-27687-1-git-send-email-selvin.xavier@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1689573194-27687-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Sun, Jul 16, 2023 at 10:53:07PM -0700, Selvin Xavier wrote: > The idea behind this series is to prevent Doorbell drops > on some of the Broadcom adapters that require Doorbell > moderation. This is achieved by pacing the doorbell writes > into the hardware FIFO. The rate at which individual doorbells > are written needs to be dynamically adjusted, because > it depends on the ability of the hardware to drain the > FIFO and on the number and behavior of individual > doorbell writers. When congestion is detected by the user > library, it notifies the driver and driver adjust the > pacing parameters dynamically in a shared page, which will > be used for pacing the Doorbells. > > Currently this feature is targeted only for user applications. > The corresponding user lib patch is in the pull request. > https://github.com/linux-rdma/rdma-core/pull/1360 > > Thanks, > Selivn > > v1 -> v2: > Rebased the patches on top of the latest for-next branch > > Chandramohan Akula (7): > bnxt_en: Update HW interface headers > bnxt_en: Share the bar0 address with the RoCE driver > RDMA/bnxt_re: Initialize Doorbell pacing feature > RDMA/bnxt_re: Enable pacing support for the user apps > RDMA/bnxt_re: Update alloc_page uapi for pacing > RDMA/bnxt_re: Implement doorbell pacing algorithm > RDMA/bnxt_re: Add a new uapi for driver notification Jason, any comments? Thanks > > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 27 ++++ > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 51 +++++- > drivers/infiniband/hw/bnxt_re/ib_verbs.h | 2 + > drivers/infiniband/hw/bnxt_re/main.c | 220 ++++++++++++++++++++++++++ > drivers/infiniband/hw/bnxt_re/qplib_res.h | 19 +++ > drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 54 +++++++ > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 2 +- > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 1 + > include/uapi/rdma/bnxt_re-abi.h | 7 + > 9 files changed, 379 insertions(+), 4 deletions(-) > > -- > 2.5.5 >