Re: [PATCH rdma-next] IB/mlx5: Add HW counter called rx_dct_connect

[Leon Romanovsky <leon@kernel.org>]

On Wed, Jul 19, 2023 at 09:30:53AM +0000, Mark Zhang wrote:
> On 7/19/2023 5:03 PM, Leon Romanovsky wrote:
> > External email: Use caution opening links or attachments
> > 
> > 
> > From: Shetu Ayalew <shetu@nvidia.com>
> > 
> > The rx_dct_connect counter shows the number of received connection
> > requests for the associated DCTs.
> > 
> > Signed-off-by: Shetu Ayalew <shetu@nvidia.com>
> > Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> >   drivers/infiniband/hw/mlx5/counters.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/infiniband/hw/mlx5/counters.c b/drivers/infiniband/hw/mlx5/counters.c
> > index 93257fa5aae8..14af6ff91dfa 100644
> > --- a/drivers/infiniband/hw/mlx5/counters.c
> > +++ b/drivers/infiniband/hw/mlx5/counters.c
> > @@ -40,6 +40,7 @@ static const struct mlx5_ib_counter retrans_q_cnts[] = {
> >          INIT_Q_COUNTER(packet_seq_err),
> >          INIT_Q_COUNTER(implied_nak_seq_err),
> >          INIT_Q_COUNTER(local_ack_timeout_err),
> > +       INIT_Q_COUNTER(rx_dct_connect),
> >   };
> > 
> >   static const struct mlx5_ib_counter vport_basic_q_cnts[] = {
> > --
> > 2.41.0
> > 
> 
> Just curious why it's in retrans_q_cnts[], instead of basic_q_cnts[]:

Ohh, you are right, it should be basic_q_cnts.

Thanks Mark.

> 
> diff --git a/drivers/infiniband/hw/mlx5/counters.c 
> b/drivers/infiniband/hw/mlx5/counters.c
> index 93257fa5aae8..8300ce622835 100644
> --- a/drivers/infiniband/hw/mlx5/counters.c
> +++ b/drivers/infiniband/hw/mlx5/counters.c
> @@ -27,6 +27,7 @@ static const struct mlx5_ib_counter basic_q_cnts[] = {
>          INIT_Q_COUNTER(rx_write_requests),
>          INIT_Q_COUNTER(rx_read_requests),
>          INIT_Q_COUNTER(rx_atomic_requests),
> +       INIT_Q_COUNTER(rx_dct_connect),
>          INIT_Q_COUNTER(out_of_buffer),
>   };
> 
> @@ -46,6 +47,7 @@ static const struct mlx5_ib_counter 
> vport_basic_q_cnts[] = {
>          INIT_VPORT_Q_COUNTER(rx_write_requests),
>          INIT_VPORT_Q_COUNTER(rx_read_requests),
>          INIT_VPORT_Q_COUNTER(rx_atomic_requests),
> +       INIT_VPORT_Q_COUNTER(rx_dct_connect),
>          INIT_VPORT_Q_COUNTER(out_of_buffer),
>   };