From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F14CE7A8C for ; Mon, 25 Sep 2023 15:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbjIYPwc (ORCPT ); Mon, 25 Sep 2023 11:52:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231332AbjIYPwb (ORCPT ); Mon, 25 Sep 2023 11:52:31 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D1D8CE for ; Mon, 25 Sep 2023 08:52:24 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-d84f18e908aso7269715276.1 for ; Mon, 25 Sep 2023 08:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695657143; x=1696261943; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7Koh5rkh3Eo1xWzvMCWLKBrOvFS2mu6zjkbegt/AyKE=; b=aZUwOV6ILDwosSLLNPn0Wp/REoXpPKAdcq+1gSFK3fNaPKeIZkEBZSHCEMyl4wd8iE BSqWxye3HM/jAOJ4L7BV1BCP9u0EhmyDIvbI6HsXxpohA8O69OzdgutVYuyLlXs1CuC2 ZuM65yaeSJrK5ShTW9ZKzApOLfPAvJW1swLq/V9M/AY5XMhWIR8Qo2lS768ycNLdMxS8 4Qj1Om95k1/LO0hGaq25WYkpxov+YEwYJJ56vai1nf0tKmUXR0vHmd8WclDdGLqcBAQB Ka5v07IJBOIbfWbpT53S/uHMZE6ipZR/g1Si/2k5vVTaVByFE9EAT7YeWYa3vSQhXmlt Vxag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695657143; x=1696261943; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Koh5rkh3Eo1xWzvMCWLKBrOvFS2mu6zjkbegt/AyKE=; b=YM3nYf2m9XAMv//0fE/eHwnxCQUeae713RaiOtlWg26QYeiYh/ufMj9jO+/DJDabbn yvt1ZfyussbEW571ALkpKaekXw1mNPR3g64W9GcOtH1grUxzkxgbaV2LYLwan6RHIICb 1mQDeDZH1IHrZk9PHITf8Z9yCn0mtX6Wc3LeEXVVgceoboyBxnud1rtKXT+MguVTgZ9H 14J/EpuFzpN5GhqK5aux+rhcbh37f8veu90GJUGEpQSe/P0EjlNXKE/AUExn/j4Ki65L tXcxG2LiUlU4pwvZfgedyz0zy4MCEV0ySRqgLWx56BYChTMZlhngVcHWRdymzaB5jBGx 2LZg== X-Gm-Message-State: AOJu0YythALbEp90y0rwLUiOPMQUvOLDeEw33/qxWdxAJ7cgpxKjX24C AwIwQjdMrRIHCIW4Fo9HSYXD1A== X-Google-Smtp-Source: AGHT+IETMJJ3Syd+giRYotIiH58lI08Wnu0bG0v+wTl03Z79gY+ToIJxWQcTE2nT7ZCSEubke6DUig== X-Received: by 2002:a25:4683:0:b0:d71:8e8c:5233 with SMTP id t125-20020a254683000000b00d718e8c5233mr5926005yba.12.1695657143361; Mon, 25 Sep 2023 08:52:23 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id b2-20020a0cb3c2000000b0065b08bb01b1sm1329874qvf.60.2023.09.25.08.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 08:52:22 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qknsk-0012CO-73; Mon, 25 Sep 2023 12:52:22 -0300 Date: Mon, 25 Sep 2023 12:52:22 -0300 From: Jason Gunthorpe To: Bart Van Assche Cc: "Daisuke Matsuda (Fujitsu)" , 'Rain River' , Bob Pearson , Zhu Yanjun , "leon@kernel.org" , Shinichiro Kawasaki , RDMA mailing list , "linux-scsi@vger.kernel.org" Subject: Re: [bug report] blktests srp/002 hang Message-ID: <20230925155222.GL13795@ziepe.ca> References: <02d7cbf2-b17b-488a-b6e9-ebb728b51c94@acm.org> <8aff9124-85c0-8e3b-dc35-1017b1540037@gmail.com> <3c84da83-cdbb-3326-b3f0-b2dee5f014e0@linux.dev> <4e7aac82-f006-aaa7-6769-d1c9691a0cec@gmail.com> <29c5de53-cc61-4efc-8e8d-690e27756a16@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29c5de53-cc61-4efc-8e8d-690e27756a16@acm.org> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Sep 25, 2023 at 08:00:39AM -0700, Bart Van Assche wrote: > On 9/24/23 21:47, Daisuke Matsuda (Fujitsu) wrote: > > As Bob wrote above, nobody has found any logical failure in rxe > > driver. > > That's wrong. In case you would not yet have noticed my latest email in > this thread, please take a look at > https://lore.kernel.org/linux-rdma/e8b76fae-780a-470e-8ec4-c6b650793d10@leemhuis.info/T/#m0fd8ea8a4cbc27b37b042ae4f8e9b024f1871a73. > I think the report in that email is a 100% proof that there is a > use-after-free issue in the rdma_rxe driver. Use-after-free issues have > security implications and also can cause data corruption. I propose to > revert the commit that introduced the rdma_rxe use-after-free unless someone > comes up with a fix for the rdma_rxe driver. I should say I'm not keen on reverting improvements to rxe. This stuff needs to happen eventually. Let's please try hard to fix it. Jason