From: Leon Romanovsky <leonro@nvidia.com>
To: Mark Zhang <markzhang@nvidia.com>
Cc: <jgg@nvidia.com>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next] RDMA/cma: Initialize traffic_class to 0 for multicast path records
Date: Wed, 27 Sep 2023 08:49:04 +0300 [thread overview]
Message-ID: <20230927054904.GO1642130@unreal> (raw)
In-Reply-To: <ad6ba804-0a58-589a-ef0c-0a012c47d3dc@nvidia.com>
On Wed, Sep 27, 2023 at 10:30:47AM +0800, Mark Zhang wrote:
> On 9/26/2023 7:09 PM, Leon Romanovsky wrote:
> > On Tue, Sep 26, 2023 at 10:25:41AM +0300, Mark Zhang wrote:
> > > Initialize traffic_class to 0 so that it wouldn't have a random value,
> > > which causes a random IP DSCP in RoCEv2.
> >
> > It will be great to see call trace which explains how. I think that
> > ib.rec.sl has same issue.
>
> Yes ib.rec.sl and ib.rec.flow_label should have the same issue, I just not
> able to reproduce as somehow they are 0 in my setups.
>
> These fields will be used to generate the ah:
> cma_iboe_join_multicast
> cma_make_mc_event
> ib_init_ah_from_mcmember
>
> > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> > index c343edf2f664..1e2cd7c8716e 100644
> > --- a/drivers/infiniband/core/cma.c
> > +++ b/drivers/infiniband/core/cma.c
> > @@ -4968,7 +4968,7 @@ static int cma_iboe_join_multicast(struct rdma_id_private *id_priv,
> > int err = 0;
> > struct sockaddr *addr = (struct sockaddr *)&mc->addr;
> > struct net_device *ndev = NULL;
> > - struct ib_sa_multicast ib;
> > + struct ib_sa_multicast ib = {};
> > enum ib_gid_type gid_type;
> > bool send_only;
>
> I think this patch is great. So what should I do now? Send this as v1, or
> you will do it?
Send v1 with updated commit message.
Thanks
>
> Thanks
>
> > Thanks
> >
> > >
> > > Fixes: b5de0c60cc30 ("RDMA/cma: Fix use after free race in roce multicast join")
> > > Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> > > ---
> > > drivers/infiniband/core/cma.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> > > index c343edf2f664..d3a72f4b9863 100644
> > > --- a/drivers/infiniband/core/cma.c
> > > +++ b/drivers/infiniband/core/cma.c
> > > @@ -4990,6 +4990,7 @@ static int cma_iboe_join_multicast(struct rdma_id_private *id_priv,
> > > ib.rec.rate = IB_RATE_PORT_CURRENT;
> > > ib.rec.hop_limit = 1;
> > > ib.rec.mtu = iboe_get_mtu(ndev->mtu);
> > > + ib.rec.traffic_class = 0;
> > > if (addr->sa_family == AF_INET) {
> > > if (gid_type == IB_GID_TYPE_ROCE_UDP_ENCAP) {
> > > --
> > > 2.37.1
> > >
>
prev parent reply other threads:[~2023-09-27 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 7:25 [PATCH rdma-next] RDMA/cma: Initialize traffic_class to 0 for multicast path records Mark Zhang
2023-09-26 11:09 ` Leon Romanovsky
2023-09-27 2:30 ` Mark Zhang
2023-09-27 5:49 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927054904.GO1642130@unreal \
--to=leonro@nvidia.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox