From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: bmt@zurich.ibm.com, jgg@ziepe.ca, leon@kernel.org
Cc: linux-rdma@vger.kernel.org
Subject: [PATCH V3 09/18] RDMA/siw: Introduce SIW_STAG_MAX_INDEX
Date: Fri, 27 Oct 2023 10:33:19 +0800 [thread overview]
Message-ID: <20231027023328.30347-10-guoqing.jiang@linux.dev> (raw)
In-Reply-To: <20231027023328.30347-1-guoqing.jiang@linux.dev>
Add the macro to remove magic number in the code.
Acked-by: Bernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
drivers/infiniband/sw/siw/siw_mem.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/sw/siw/siw_mem.c b/drivers/infiniband/sw/siw/siw_mem.c
index 92c5776a9eed..ac4502fb0a96 100644
--- a/drivers/infiniband/sw/siw/siw_mem.c
+++ b/drivers/infiniband/sw/siw/siw_mem.c
@@ -13,18 +13,20 @@
#include "siw.h"
#include "siw_mem.h"
+/* Stag lookup is based on its index part only (24 bits). */
+#define SIW_STAG_MAX_INDEX 0x00ffffff
+
/*
- * Stag lookup is based on its index part only (24 bits).
* The code avoids special Stag of zero and tries to randomize
* STag values between 1 and SIW_STAG_MAX_INDEX.
*/
int siw_mem_add(struct siw_device *sdev, struct siw_mem *m)
{
- struct xa_limit limit = XA_LIMIT(1, 0x00ffffff);
+ struct xa_limit limit = XA_LIMIT(1, SIW_STAG_MAX_INDEX);
u32 id, next;
get_random_bytes(&next, 4);
- next &= 0x00ffffff;
+ next &= SIW_STAG_MAX_INDEX;
if (xa_alloc_cyclic(&sdev->mem_xa, &id, m, limit, &next,
GFP_KERNEL) < 0)
@@ -91,7 +93,7 @@ int siw_mr_add_mem(struct siw_mr *mr, struct ib_pd *pd, void *mem_obj,
{
struct siw_device *sdev = to_siw_dev(pd->device);
struct siw_mem *mem = kzalloc(sizeof(*mem), GFP_KERNEL);
- struct xa_limit limit = XA_LIMIT(1, 0x00ffffff);
+ struct xa_limit limit = XA_LIMIT(1, SIW_STAG_MAX_INDEX);
u32 id, next;
if (!mem)
@@ -107,7 +109,7 @@ int siw_mr_add_mem(struct siw_mr *mr, struct ib_pd *pd, void *mem_obj,
kref_init(&mem->ref);
get_random_bytes(&next, 4);
- next &= 0x00ffffff;
+ next &= SIW_STAG_MAX_INDEX;
if (xa_alloc_cyclic(&sdev->mem_xa, &id, mem, limit, &next,
GFP_KERNEL) < 0) {
--
2.35.3
next prev parent reply other threads:[~2023-10-27 2:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 2:33 [PATCH V3 00/18] Cleanup for siw Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 01/18] RDMA/siw: Introduce siw_get_page Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 02/18] RDMA/siw: Introduce siw_update_skb_rcvd Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 03/18] RDMA/siw: Use iov.iov_len in kernel_sendmsg Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 04/18] RDMA/siw: Remove goto lable in siw_mmap Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 05/18] RDMA/siw: Remove rcu from siw_qp Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 06/18] RDMA/siw: No need to check term_info.valid before call siw_send_terminate Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 07/18] RDMA/siw: Also goto out_sem_up if pin_user_pages returns 0 Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 08/18] RDMA/siw: Factor out siw_generic_rx helper Guoqing Jiang
2023-10-27 2:33 ` Guoqing Jiang [this message]
2023-10-27 2:33 ` [PATCH V3 10/18] RDMA/siw: Add one parameter to siw_destroy_cpulist Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 11/18] RDMA/siw: Introduce siw_cep_set_free_and_put Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 12/18] RDMA/siw: Introduce siw_free_cm_id Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 13/18] RDMA/siw: Cleanup siw_accept Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 14/18] RDMA/siw: Remove siw_sk_save_upcalls Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 15/18] RDMA/siw: Fix typo Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 16/18] RDMA/siw: Only check attrs->cap.max_send_wr in siw_create_qp Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 17/18] RDMA/siw: Introduce siw_destroy_cep_sock Guoqing Jiang
2023-10-27 2:33 ` [PATCH V3 18/18] RDMA/siw: Update comments for siw_qp_sq_process Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027023328.30347-10-guoqing.jiang@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=bmt@zurich.ibm.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).