From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Moshe Shemesh <moshe@nvidia.com>,
linux-rdma@vger.kernel.org,
Michael Guralnik <michaelgur@nvidia.com>,
Shay Drory <shayd@nvidia.com>
Subject: Re: [PATCH rdma-rc] RDMA/mlx5: Fix mkey cache WQ flush
Date: Tue, 31 Oct 2023 11:06:12 -0300 [thread overview]
Message-ID: <20231031140612.GA1846982@nvidia.com> (raw)
In-Reply-To: <b8722f14e7ed81452f791764a26d2ed4cfa11478.1698256179.git.leon@kernel.org>
On Wed, Oct 25, 2023 at 08:49:59PM +0300, Leon Romanovsky wrote:
> From: Moshe Shemesh <moshe@nvidia.com>
>
> The cited patch tries to ensure no pending works on the mkey cache
> workqueue by disabling adding new works and call flush_workqueue().
> But this workqueue also has delayed works which might still be pending
> the delay time to be queued.
>
> Add cancel_delayed_work() for the delayed works which waits to be queued
> and then the flush_workqueue() will flush all works which are already
> queued and running.
>
> Fixes: 374012b00457 ("RDMA/mlx5: Fix mkey cache possible deadlock on cleanup")
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2023-10-31 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 17:49 [PATCH rdma-rc] RDMA/mlx5: Fix mkey cache WQ flush Leon Romanovsky
2023-10-31 14:06 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031140612.GA1846982@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
--cc=moshe@nvidia.com \
--cc=shayd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).