From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006D0C072A2 for ; Sun, 19 Nov 2023 13:13:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229659AbjKSNNK (ORCPT ); Sun, 19 Nov 2023 08:13:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjKSNNK (ORCPT ); Sun, 19 Nov 2023 08:13:10 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A208BC; Sun, 19 Nov 2023 05:13:07 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17605C433C9; Sun, 19 Nov 2023 13:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700399586; bh=U7USW0R0NtK5jKBGaPoJXwIxYcVtCri8oCrDMLqVZBs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R+ie0+clo6+LeDv+eu2DiBK2e3dEFWtLqYf//caMrRdyJTdf8zbXs/f706BWXOt7a NB0U5qIQPiGLOAwcc/SYNnf9bzpb70vngCSk6AXPbVUB2sfnN6eImgaVPUOU9dAbfC Q3YrXXgm57PUdHghY+LiFvC3gO67ZylkXz42lgVyTFLYyrQ/S1bGr1UG5gJ1z2GK5w tdHAWN8DgaIc3SEV1r3v5LTy/BOkv5PHyE5r1NKf8vhV5ZJdDHLCX94P2yvBGbNrR4 zW9GW5n7ztBR37Bb8xdY+Da/thw0DBAkrsBy/gZYGR8IKISgPzMQPRztdR36BnnG1/ Oy1X9s7euCLqg== Date: Sun, 19 Nov 2023 15:13:02 +0200 From: Leon Romanovsky To: Shifeng Li Cc: mustafa.ismail@intel.com, shiraz.saleem@intel.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, dinghui@sangfor.com.cn Subject: Re: [PATCH] RDMA/irdma: Fix UAF in irdma_sc_ccq_get_cqe_info() Message-ID: <20231119131302.GB15293@unreal> References: <20231117065043.3822-1-lishifeng1992@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231117065043.3822-1-lishifeng1992@126.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Nov 16, 2023 at 10:50:43PM -0800, Shifeng Li wrote: > When removing the irdma driver or unplugging its aux device, the ccq > queue is released before destorying the cqp_cmpl_wq queue. > But in the window, there may still be completion events for wqes. That > will cause a UAF in irdma_sc_ccq_get_cqe_info(). > > [34693.333191] BUG: KASAN: use-after-free in irdma_sc_ccq_get_cqe_info+0x82f/0x8c0 [irdma] > [34693.333194] Read of size 8 at addr ffff889097f80818 by task kworker/u67:1/26327 > [34693.333194] > [34693.333199] CPU: 9 PID: 26327 Comm: kworker/u67:1 Kdump: loaded Tainted: G O --------- -t - 4.18.0 #1 > [34693.333200] Hardware name: SANGFOR Inspur/NULL, BIOS 4.1.13 08/01/2016 > [34693.333211] Workqueue: cqp_cmpl_wq cqp_compl_worker [irdma] > [34693.333213] Call Trace: > [34693.333220] dump_stack+0x71/0xab > [34693.333226] print_address_description+0x6b/0x290 > [34693.333238] ? irdma_sc_ccq_get_cqe_info+0x82f/0x8c0 [irdma] > [34693.333240] kasan_report+0x14a/0x2b0 > [34693.333251] irdma_sc_ccq_get_cqe_info+0x82f/0x8c0 [irdma] > [34693.333264] ? irdma_free_cqp_request+0x151/0x1e0 [irdma] > [34693.333274] irdma_cqp_ce_handler+0x1fb/0x3b0 [irdma] > [34693.333285] ? irdma_ctrl_init_hw+0x2c20/0x2c20 [irdma] > [34693.333290] ? __schedule+0x836/0x1570 > [34693.333293] ? strscpy+0x83/0x180 > [34693.333296] process_one_work+0x56a/0x11f0 > [34693.333298] worker_thread+0x8f/0xf40 > [34693.333301] ? __kthread_parkme+0x78/0xf0 > [34693.333303] ? rescuer_thread+0xc50/0xc50 > [34693.333305] kthread+0x2a0/0x390 > [34693.333308] ? kthread_destroy_worker+0x90/0x90 > [34693.333310] ret_from_fork+0x1f/0x40 > > Signed-off-by: Shifeng Li > --- > drivers/infiniband/hw/irdma/hw.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Please add Fixes line and resubmit together with Shiraz's Acked-by, Thanks