From: Junxian Huang <huangjunxian6@hisilicon.com>
To: <jgg@ziepe.ca>, <leon@kernel.org>
Cc: <linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>, <huangjunxian6@hisilicon.com>
Subject: [PATCH for-rc 5/6] RDMA/hns: Fix memory leak in free_mr_init()
Date: Wed, 29 Nov 2023 17:44:33 +0800 [thread overview]
Message-ID: <20231129094434.134528-6-huangjunxian6@hisilicon.com> (raw)
In-Reply-To: <20231129094434.134528-1-huangjunxian6@hisilicon.com>
From: Chengchang Tang <tangchengchang@huawei.com>
When a reserved QP fails to be created, the memory of the remaining
created reserved QPs is leaked.
Fixes: 70f92521584f ("RDMA/hns: Use the reserved loopback QPs to free MR before destroying MPT")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 8126922b4e21..538f3e8949fc 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -2705,6 +2705,10 @@ static int free_mr_alloc_res(struct hns_roce_dev *hr_dev)
return 0;
create_failed_qp:
+ for (i--; i >= 0; i--) {
+ hns_roce_v2_destroy_qp(&free_mr->rsv_qp[i]->ibqp, NULL);
+ kfree(free_mr->rsv_qp[i]);
+ }
hns_roce_destroy_cq(cq, NULL);
kfree(cq);
--
2.30.0
next prev parent reply other threads:[~2023-11-29 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 9:44 [PATCH for-rc 0/6] Bugfixes and improvements for hns RoCE Junxian Huang
2023-11-29 9:44 ` [PATCH for-rc 1/6] RDMA/hns: Rename the interrupts Junxian Huang
2023-11-29 9:44 ` [PATCH for-rc 2/6] RDMA/hns: Response dmac to userspace Junxian Huang
2023-11-29 9:44 ` [PATCH for-rc 3/6] RDMA/hns: Add a max length of gid table Junxian Huang
2023-11-29 9:44 ` [PATCH for-rc 4/6] RDMA/hns: Remove unnecessary checks for NULL in mtr_alloc_bufs() Junxian Huang
2023-11-29 9:44 ` Junxian Huang [this message]
2023-11-29 9:44 ` [PATCH for-rc 6/6] RDMA/hns: Improve the readability of free mr uninit Junxian Huang
2023-12-06 5:04 ` kernel test robot
2023-12-04 14:24 ` [PATCH for-rc 0/6] Bugfixes and improvements for hns RoCE Leon Romanovsky
2023-12-05 2:05 ` Junxian Huang
2023-12-06 14:27 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129094434.134528-6-huangjunxian6@hisilicon.com \
--to=huangjunxian6@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox