Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: yanjun.zhu@linux.dev, jgg@ziepe.ca, leon@kernel.org,
	linux-rdma@vger.kernel.org, jhack@hpe.com
Cc: Bob Pearson <rpearsonhpe@gmail.com>
Subject: [PATCH for-next 06/11] RDMA/rxe: Don't schedule rxe_completer() in rxe_requester()
Date: Tue, 26 Mar 2024 12:43:21 -0500	[thread overview]
Message-ID: <20240326174325.300849-8-rpearsonhpe@gmail.com> (raw)
In-Reply-To: <20240326174325.300849-2-rpearsonhpe@gmail.com>

Now that rxe_completer() is always called serially after
rxe_requester() there is no reason to schedule rxe_completer()
in rxe_requester().

Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
---
 drivers/infiniband/sw/rxe/rxe_req.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index e20462c3040d..b217fa94ff03 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -631,12 +631,6 @@ static int rxe_do_local_ops(struct rxe_qp *qp, struct rxe_send_wqe *wqe)
 	wqe->status = IB_WC_SUCCESS;
 	qp->req.wqe_index = queue_next_index(qp->sq.queue, qp->req.wqe_index);
 
-	/* There is no ack coming for local work requests
-	 * which can lead to a deadlock. So go ahead and complete
-	 * it now.
-	 */
-	rxe_sched_task(&qp->send_task);
-
 	return 0;
 }
 
@@ -760,7 +754,6 @@ int rxe_requester(struct rxe_qp *qp)
 						       qp->req.wqe_index);
 			wqe->state = wqe_state_done;
 			wqe->status = IB_WC_SUCCESS;
-			rxe_sched_task(&qp->send_task);
 			goto done;
 		}
 		payload = mtu;
-- 
2.43.0


  parent reply	other threads:[~2024-03-26 17:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 17:43 [PATCH for-next 00/11] RDMA/rxe: Various fixes and cleanups Bob Pearson
2024-03-26 17:43 ` [PATCH for-next 01/11] RDMA/rxe: Fix seg fault in rxe_comp_queue_pkt Bob Pearson
2024-04-02 12:31   ` Leon Romanovsky
2024-03-26 17:43 ` [PATCH for-next 02/11] RDMA/rxe: Allow good work requests to be executed Bob Pearson
2024-04-02 12:57   ` Zhu Yanjun
2024-03-26 17:43 ` [PATCH for-next 03/11] RDMA/rxe: Remove redundant scheduling of rxe_completer Bob Pearson
2024-03-26 17:43 ` [PATCH for-next 04/11] RDMA/rxe: Merge request and complete tasks Bob Pearson
2024-03-26 17:43 ` [PATCH for-next 05/11] RDMA/rxe: Remove save/rollback_state in rxe_requester Bob Pearson
2024-03-26 17:43 ` Bob Pearson [this message]
2024-03-26 17:43 ` [PATCH for-next 07/11] RDMA/rxe: Don't call rxe_requester from rxe_completer Bob Pearson
2024-04-02 12:29   ` Leon Romanovsky
2024-03-26 17:43 ` [PATCH for-next 08/11] RDMA/rxe: Don't call direct between tasks Bob Pearson
2024-03-26 17:43 ` [PATCH for-next 09/11] RDMA/rxe: Fix incorrect rxe_put in error path Bob Pearson
2024-03-26 17:43 ` [PATCH for-next 10/11] RDMA/rxe: Make rxe_loopback match rxe_send behavior Bob Pearson
2024-03-26 17:43 ` [PATCH for-next 11/11] RDMA/rxe: Get rid of pkt resend on err Bob Pearson
2024-03-26 19:01 ` [PATCH for-next 00/11] RDMA/rxe: Various fixes and cleanups Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326174325.300849-8-rpearsonhpe@gmail.com \
    --to=rpearsonhpe@gmail.com \
    --cc=jgg@ziepe.ca \
    --cc=jhack@hpe.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox