linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, sharmaajay@microsoft.com,
	longli@microsoft.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next v4 0/4] Define and use mana queues for CQs and WQs
Date: Mon, 8 Apr 2024 14:25:33 +0300	[thread overview]
Message-ID: <20240408112533.GF8764@unreal> (raw)
In-Reply-To: <1712567646-5247-1-git-send-email-kotaranov@linux.microsoft.com>

On Mon, Apr 08, 2024 at 02:14:02AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> This patch series aims to reduce code duplication by
> introducing a notion of mana ib queues and corresponding helpers
> to create and destroy them.
> 
> v3->v4:
> * Removed debug prints in patches, as asked by Leon
> 
> v2->v3:
> * [in 4/4] Do not define an additional struct for a raw qp
> 
> v1->v2:
> * [in 1/4] Added a comment about the ignored return value
> * [in 2/4] Replaced RDMA:mana_ib to RDMA/mana_ib in the subject
> * [in 4/4] Renamed mana_ib_raw_qp to mana_ib_raw_sq
> 
> Konstantin Taranov (4):
>   RDMA/mana_ib: Introduce helpers to create and destroy mana queues
>   RDMA/mana_ib: Use struct mana_ib_queue for CQs
>   RDMA/mana_ib: Use struct mana_ib_queue for WQs
>   RDMA/mana_ib: Use struct mana_ib_queue for RAW QPs
> 
>  drivers/infiniband/hw/mana/cq.c      | 52 +++-------------
>  drivers/infiniband/hw/mana/main.c    | 39 ++++++++++++
>  drivers/infiniband/hw/mana/mana_ib.h | 26 ++++----
>  drivers/infiniband/hw/mana/qp.c      | 93 +++++++++-------------------
>  drivers/infiniband/hw/mana/wq.c      | 33 ++--------
>  5 files changed, 96 insertions(+), 147 deletions(-)

It doesn't apply.

Grabbing thread from lore.kernel.org/all/1712567646-5247-1-git-send-email-kotaranov@linux.microsoft.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 5 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
Retrieving CI status, may take a moment...
---
  ✓ [PATCH v4 1/4] RDMA/mana_ib: Introduce helpers to create and destroy mana queues
    + Link: https://lore.kernel.org/r/1712567646-5247-2-git-send-email-kotaranov@linux.microsoft.com
    + Signed-off-by: Leon Romanovsky <leon@kernel.org>
  ✓ [PATCH v4 2/4] RDMA/mana_ib: Use struct mana_ib_queue for CQs
    + Link: https://lore.kernel.org/r/1712567646-5247-3-git-send-email-kotaranov@linux.microsoft.com
    + Signed-off-by: Leon Romanovsky <leon@kernel.org>
  ✓ [PATCH v4 3/4] RDMA/mana_ib: Use struct mana_ib_queue for WQs
    + Link: https://lore.kernel.org/r/1712567646-5247-4-git-send-email-kotaranov@linux.microsoft.com
    + Signed-off-by: Leon Romanovsky <leon@kernel.org>
  ✓ [PATCH v4 4/4] RDMA/mana_ib: Use struct mana_ib_queue for RAW QPs
    + Link: https://lore.kernel.org/r/1712567646-5247-5-git-send-email-kotaranov@linux.microsoft.com
    + Signed-off-by: Leon Romanovsky <leon@kernel.org>
  ---
  ✓ Signed: DKIM/linux.microsoft.com
---
Total patches: 4
---
 Base: using specified base-commit 96d9cbe2f2ff7abde021bac75eafaceabe9a51fa
Applying: RDMA/mana_ib: Introduce helpers to create and destroy mana queues
Patch failed at 0001 RDMA/mana_ib: Introduce helpers to create and destroy mana queues
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: drivers/infiniband/hw/mana/main.c:237
error: drivers/infiniband/hw/mana/main.c: patch does not apply
error: patch failed: drivers/infiniband/hw/mana/mana_ib.h:45
error: drivers/infiniband/hw/mana/mana_ib.h: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Press any key to continue...

  parent reply	other threads:[~2024-04-08 11:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  9:14 [PATCH rdma-next v4 0/4] Define and use mana queues for CQs and WQs Konstantin Taranov
2024-04-08  9:14 ` [PATCH rdma-next v4 1/4] RDMA/mana_ib: Introduce helpers to create and destroy mana queues Konstantin Taranov
2024-04-08  9:14 ` [PATCH rdma-next v4 2/4] RDMA/mana_ib: Use struct mana_ib_queue for CQs Konstantin Taranov
2024-04-08  9:14 ` [PATCH rdma-next v4 3/4] RDMA/mana_ib: Use struct mana_ib_queue for WQs Konstantin Taranov
2024-04-08  9:14 ` [PATCH rdma-next v4 4/4] RDMA/mana_ib: Use struct mana_ib_queue for RAW QPs Konstantin Taranov
2024-04-08 11:25 ` Leon Romanovsky [this message]
2024-04-08 12:50   ` [EXTERNAL] Re: [PATCH rdma-next v4 0/4] Define and use mana queues for CQs and WQs Konstantin Taranov
2024-04-08 13:00     ` Leon Romanovsky
2024-04-08 13:47       ` Konstantin Taranov
2024-04-08 14:00         ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408112533.GF8764@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kotaranov@linux.microsoft.com \
    --cc=kotaranov@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=sharmaajay@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).