public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Chuck Lever III <chuck.lever@oracle.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: Safe to delete rpcrdma.ko loading start-up code
Date: Tue, 21 May 2024 13:37:13 -0300	[thread overview]
Message-ID: <20240521163713.GL20229@nvidia.com> (raw)
In-Reply-To: <e558ee64-48fc-48b9-addd-eab7f9f861ad@grimberg.me>

On Tue, May 21, 2024 at 07:10:53PM +0300, Sagi Grimberg wrote:
> 
> 
> On 21/05/2024 18:23, Jason Gunthorpe wrote:
> > On Tue, May 21, 2024 at 05:12:23PM +0300, Sagi Grimberg wrote:
> > > > > > > I also see that srp(t) and iser(t) are loaded too.. IIRC these are
> > > > > > > loaded by their userspace counterparts as well (or at least they
> > > > > > > should).
> > > > > > And AFIAK, these don't have a way to autoload at all. autoload
> > > > > > requires the kernel to call request_module..
> > > > > nvme/nvmet/isert are requested by the kernel.
> > > > How? What is the interface to trigger request_module?
> > > On the host, writing to the nvme-fabrics misc device a comma-separated
> > > connection string
> > > contains a transport string, which triggers the corresponding module to be
> > > requested.
> > But how did nvme-fabrics even get loaded to write to it's config fs in
> > the first place?
> 
> Something (/etc/modules-load?) loaded it intentionally.
> That something knows about a concrete intention to use nvme though...

This mechanism we are talking about is an add-on to /etc/modules-load
that only executes if rdma HW is present.

This is why it is a good place to load nvme-fabrics stuff, if you
don't have rdma HW then you know you don't need it.

Autoloading is the version where you do 'mount -tnfs -o=rdma' and the
kernel automatically request_module's nfs and then nfs-rdma based only
on the command line options.

I'm not sure this is even possible with configfs as the directories
you need to write into don't even exist until the module(s) are
loaded, right?

Jason 

  reply	other threads:[~2024-05-21 16:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 18:05 Safe to delete rpcrdma.ko loading start-up code Chuck Lever III
2024-05-21  9:04 ` Sagi Grimberg
2024-05-21 12:43   ` Jason Gunthorpe
2024-05-21 13:05     ` Sagi Grimberg
2024-05-21 13:37       ` Jason Gunthorpe
2024-05-21 14:12         ` Sagi Grimberg
2024-05-21 15:23           ` Jason Gunthorpe
2024-05-21 16:10             ` Sagi Grimberg
2024-05-21 16:37               ` Jason Gunthorpe [this message]
2024-05-21 20:30                 ` Sagi Grimberg
2024-05-21 23:29                   ` Jason Gunthorpe
2024-05-22 10:50                     ` Sagi Grimberg
2024-05-22  7:57                   ` Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240521163713.GL20229@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox