public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"kheib@redhat.com" <kheib@redhat.com>,
	"edwards@nvidia.com" <edwards@nvidia.com>
Subject: Re: [bug-report]rdma-core v51.0 build error with Rocky Linux 8.8
Date: Fri, 24 May 2024 15:22:18 -0300	[thread overview]
Message-ID: <20240524182218.GT69273@ziepe.ca> (raw)
In-Reply-To: <SA1PR11MB689549B8852C1A337271747286F52@SA1PR11MB6895.namprd11.prod.outlook.com>

On Fri, May 24, 2024 at 06:01:51PM +0000, Marciniszyn, Mike wrote:
> > >
> > > This can be reproduced by loading a newer python and rebuilding the 51.0
> > rdma-core from a git clone using either 51.0 or master.
> > >
> > > An RPM based RHEL build can replace the existing PYTHON_EXECUABLE with
> > > Python_EXECUTABLE.
> > 
> > You mean at some point we lost that PYTHON_EXECUTABLE works and it got
> > renamed to Python_EXECUTABLE ?
> > 
> > Jason
> 
> The Python_EXECUTABLE is workaround that can be applied to a spec file.

OK, that is clear. If PYTHON_EXECUTABLE no longer works that is a well
understandable issue.

Something like this maybe?

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -216,6 +216,9 @@ endif()
 
 # Use Python modules based on CMake version for backward compatibility
 set(CYTHON_EXECUTABLE "")
+if (${PYTHON_EXCUTABLE})
+  set(Python_EXECUTABLE ${PYTHON_EXCUTABLE})
+endif()
 if (${CMAKE_VERSION} VERSION_LESS "3.12")
   # Look for Python. We prefer some variant of python 3 if the system has it
   FIND_PACKAGE(PythonInterp 3 QUIET)

Jason

  reply	other threads:[~2024-05-24 18:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 19:48 [bug-report]rdma-core v51.0 build error with Rocky Linux 8.8 Marciniszyn, Mike
2024-05-23 15:19 ` Jason Gunthorpe
2024-05-24 16:40   ` Marciniszyn, Mike
2024-05-24 16:57     ` Jason Gunthorpe
2024-05-24 18:01       ` Marciniszyn, Mike
2024-05-24 18:22         ` Jason Gunthorpe [this message]
2024-05-24 18:24           ` Marciniszyn, Mike
2024-05-29 18:50           ` Marciniszyn, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240524182218.GT69273@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=edwards@nvidia.com \
    --cc=kheib@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox