From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Leon Romanovsky <leonro@nvidia.com>,
linux-rdma@vger.kernel.org, Mark Zhang <markzhang@nvidia.com>,
Michael Guralnik <michaelgur@nvidia.com>,
Or Har-Toov <ohartoov@nvidia.com>,
Patrisious Haddad <phaddad@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH rdma-rc 1/6] RDMA/cache: Release GID table even if leak is detected
Date: Tue, 4 Jun 2024 13:36:36 -0300 [thread overview]
Message-ID: <20240604163636.GK19897@nvidia.com> (raw)
In-Reply-To: <a62560af06ba82c88ef9194982bfa63d14768ff9.1716900410.git.leon@kernel.org>
On Tue, May 28, 2024 at 03:52:51PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> When the table is released, we nullify pointer to GID table, it means
> that in case GID entry leak is detected, we will leak table too.
>
> Delete code that prevents table destruction.
This converts a memory leak into a UAF, it doesn't seem like a good direction??
Jason
next prev parent reply other threads:[~2024-06-04 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:52 [PATCH rdma-rc 0/6] Batch of mlx5 fixes for v6.10 Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 1/6] RDMA/cache: Release GID table even if leak is detected Leon Romanovsky
2024-06-04 16:36 ` Jason Gunthorpe [this message]
2024-06-05 9:44 ` Leon Romanovsky
2024-06-05 11:47 ` Jason Gunthorpe
2024-06-21 13:21 ` Jason Gunthorpe
2024-06-24 13:23 ` Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 2/6] RDMA/mlx5: Remove extra unlock on error path Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 3/6] RDMA/mlx5: Follow rb_key.ats when creating new mkeys Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 4/6] RDMA/mlx5: Ensure created mkeys always have a populated rb_key Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 5/6] RDMA/mlx5: Fix unwind flow as part of mlx5_ib_stage_init_init Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 6/6] RDMA/mlx5: Add check for srq max_sge attribute Leon Romanovsky
2024-06-02 8:30 ` [PATCH rdma-rc 0/6] Batch of mlx5 fixes for v6.10 Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604163636.GK19897@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=michaelgur@nvidia.com \
--cc=ohartoov@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).