Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

Allison Henderson
2024-06-04T17:52:03Z

On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

This patch looks fine to me, the struct is indeed unused at this point.
Thanks for the clean up!

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
>  net/rds/ib_rdma.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> index 8f070ee7e742..d1cfceeff133 100644
> --- a/net/rds/ib_rdma.c
> +++ b/net/rds/ib_rdma.c
> @@ -40,10 +40,6 @@
>  #include "rds.h"
>
>  struct workqueue_struct *rds_ib_mr_wq;
> -struct rds_ib_dereg_odp_mr {
> -       struct work_struct work;
> -       struct ib_mr *mr;
> -};
>
>  static void rds_ib_odp_mr_worker(struct work_struct *work);
>