From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BF5918FDB0 for ; Wed, 5 Jun 2024 09:45:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717580701; cv=none; b=QVVCmLzY6zbBwd3QcFFw7he6rfEyDXYKsqJ0tuFp49ewOa1ULm/LLQQuBI9yXe32ikU2u2T1eXZYn2x4Qe+rSA5nVr4oETvw+6vKrsjyEA9hiFJOb+33blDMpKgndfKtILJ7eytC1DuRRkYEFUMF2owGKq9KfPvRmP2jQmhtcyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717580701; c=relaxed/simple; bh=7ViuhaZ0vOQ1hkJ64ymeyVoHRmW0wh10SrFbHtwmOx8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PQmHKlZ3Sq3sK97ThhVdmNLlJEZU58GBihoEkjooqGpnrWtj38ChWTR11yYX2CSAkmZe19nYKLNZUm38IaCccy3E/efqwCFKJADgtKm04jeIQ36JtWH7a//Wd+bQg+mkGDJqBPlxvgxFJalqztVHUP+vy2EgtNzRsd04DErD0wU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uef4gJAk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uef4gJAk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A097C3277B; Wed, 5 Jun 2024 09:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717580700; bh=7ViuhaZ0vOQ1hkJ64ymeyVoHRmW0wh10SrFbHtwmOx8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uef4gJAkLqlydWHUl2ak7SEESIBIvhd5O/mIcxqEHp2ke28HqbGJXW5mUTI12fb/0 au1QDb+rprRhgyQCrgS6o8GCOynsbs28SntKhcRbDkKDeGeXvjqOPZsk0gyCQgB1zc FIvfmhg33Ai3TtNwP9Kl0ZFkPe0FM14myJcf6iEez8tFVfjjS3GDvRv4x15jXBIS6P hUE+sWSxcnJvRFB7BRcKEH51M/cTvhYBdIoxHaCJQcWCj5Ld5rJJW2N0HOZGb72kaP fsMrYl50HY6LfPdFHCfgqdNYDhs1JA3sJSQ634icSj4IA3A5Pudfcx+j+YO+fr09xR YHdZZjUJihWLQ== Date: Wed, 5 Jun 2024 12:44:56 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, Mark Zhang , Michael Guralnik , Or Har-Toov , Patrisious Haddad , Yishai Hadas Subject: Re: [PATCH rdma-rc 1/6] RDMA/cache: Release GID table even if leak is detected Message-ID: <20240605094456.GA19021@unreal> References: <20240604163636.GK19897@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240604163636.GK19897@nvidia.com> On Tue, Jun 04, 2024 at 01:36:36PM -0300, Jason Gunthorpe wrote: > On Tue, May 28, 2024 at 03:52:51PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > When the table is released, we nullify pointer to GID table, it means > > that in case GID entry leak is detected, we will leak table too. > > > > Delete code that prevents table destruction. > > This converts a memory leak into a UAF, it doesn't seem like a good direction?? Maybe we should convert dev_err() to be WARN_ON(). I didn't see any complains about GID entry leaks. It is debug print. Thanks > > Jason >