From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: netdev@vger.kernel.org
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Edward Cree" <ecree.xilinx@gmail.com>,
"Martin Habets" <habetsm.xilinx@gmail.com>,
linux-net-drivers@amd.com, "Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
linux-rdma@vger.kernel.org,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org,
"Louis Peens" <louis.peens@corigine.com>,
oss-drivers@corigine.com, linux-kernel@vger.kernel.org,
"Davide Caratti" <dcaratti@redhat.com>,
i.maximets@ovn.org
Subject: [PATCH net-next 0/5] net: flower: validate encapsulation control flags
Date: Sun, 9 Jun 2024 17:33:50 +0000 [thread overview]
Message-ID: <20240609173358.193178-1-ast@fiberby.net> (raw)
Now that all drivers properly rejects unsupported flower control flags
used with FLOW_DISSECTOR_KEY_CONTROL, then time has come to add similar
checks to the drivers supporting FLOW_DISSECTOR_KEY_ENC_CONTROL.
There are currently just 4 drivers supporting this key, and
3 of those currently doesn't validate encapsulated control flags.
Encapsulation control flags may currently be unused, but they should
still be validated by the drivers, so that drivers will properly
reject any new flags when they are introduced.
This series adds some helper functions, and implements them in all
4 drivers.
NB: It is currently discussed[1] to use encapsulation control flags
for tunnel flags instead of the new FLOW_DISSECTOR_KEY_ENC_FLAGS.
[1] https://lore.kernel.org/netdev/ZmFuxElwZiYJzBkh@dcaratti.users.ipa.redhat.com/
Asbjørn Sloth Tønnesen (5):
flow_offload: add encapsulation control flag helpers
sfc: use flow_rule_is_supp_enc_control_flags()
net/mlx5e: flower: validate encapsulation control flags
nfp: flower: validate encapsulation control flags
ice: flower: validate encapsulation control flags
drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 +++
.../ethernet/mellanox/mlx5/core/en/tc_tun.c | 6 ++++
.../ethernet/netronome/nfp/flower/offload.c | 4 +++
drivers/net/ethernet/sfc/tc.c | 5 +--
include/net/flow_offload.h | 35 +++++++++++++++++++
5 files changed, 50 insertions(+), 4 deletions(-)
--
2.45.1
next reply other threads:[~2024-06-09 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 17:33 Asbjørn Sloth Tønnesen [this message]
2024-06-09 17:33 ` [PATCH net-next 1/5] flow_offload: add encapsulation control flag helpers Asbjørn Sloth Tønnesen
2024-06-09 17:33 ` [PATCH net-next 2/5] sfc: use flow_rule_is_supp_enc_control_flags() Asbjørn Sloth Tønnesen
2024-06-10 19:31 ` Edward Cree
2024-06-09 17:33 ` [PATCH net-next 3/5] net/mlx5e: flower: validate encapsulation control flags Asbjørn Sloth Tønnesen
2024-06-09 17:33 ` [PATCH net-next 4/5] nfp: " Asbjørn Sloth Tønnesen
2024-06-11 7:24 ` Louis Peens
2024-06-09 17:33 ` [PATCH net-next 5/5] ice: " Asbjørn Sloth Tønnesen
2024-06-10 9:06 ` [Intel-wired-lan] " Marcin Szycik
2024-06-11 9:09 ` [PATCH net-next 0/5] net: " Davide Caratti
2024-06-13 1:04 ` Jakub Kicinski
2024-06-13 17:38 ` Asbjørn Sloth Tønnesen
2024-06-13 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240609173358.193178-1-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=i.maximets@ovn.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux-rdma@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox