Open-coded get_netdev implementation in MANA IB

Open-coded get_netdev implementation in MANA IB

[Leon Romanovsky]

Hi,

I looked again on the patch 3b73eb3a4acd ("RDMA/mana_ib: Introduce mana_ib_get_netdev helper function")
and wonder if it is correct thing to do.

All new drivers shouldn't open-code get_netdev() and use the helpers ib_device_get_netdev() and
ib_device_set_netdev() instead of storing netdev in the driver.

Can you please convert MANA IB driver to proper API usage?

Thanks

RE: Open-coded get_netdev implementation in MANA IB

[Konstantin Taranov]

> Hi,
> 
> I looked again on the patch 3b73eb3a4acd ("RDMA/mana_ib: Introduce
> mana_ib_get_netdev helper function") and wonder if it is correct thing to do.
> 
> All new drivers shouldn't open-code get_netdev() and use the helpers
> ib_device_get_netdev() and
> ib_device_set_netdev() instead of storing netdev in the driver.
> 
> Can you please convert MANA IB driver to proper API usage?

Hi Leon,

This helper was introduced to remove a boiler plate code which was getting
the netdev from gc->mana.driver_data. I sure can fix it and use ib_device_get_netdev api.

Should I send it to the rdma-next on the top of the latest commit?

Thanks

> 
> Thanks

Re: Open-coded get_netdev implementation in MANA IB

[Leon Romanovsky]

On Mon, Jun 17, 2024 at 12:11:50PM +0000, Konstantin Taranov wrote:
> > Hi,
> > 
> > I looked again on the patch 3b73eb3a4acd ("RDMA/mana_ib: Introduce
> > mana_ib_get_netdev helper function") and wonder if it is correct thing to do.
> > 
> > All new drivers shouldn't open-code get_netdev() and use the helpers
> > ib_device_get_netdev() and
> > ib_device_set_netdev() instead of storing netdev in the driver.
> > 
> > Can you please convert MANA IB driver to proper API usage?
> 
> Hi Leon,
> 
> This helper was introduced to remove a boiler plate code which was getting
> the netdev from gc->mana.driver_data. 

Yes, the thing is that probably we were supposed to move to
ib_device_get_netdev() and don't invest time in mana_ib_get_netdev()
helper at all.

> I sure can fix it and use ib_device_get_netdev api.
> 
> Should I send it to the rdma-next on the top of the latest commit?

Yes, please.

> 
> Thanks
> 
> > 
> > Thanks

Re: Open-coded get_netdev implementation in MANA IB

[Konstantin Taranov]

> Yes, the thing is that probably we were supposed to move to
> ib_device_get_netdev() and don't invest time in mana_ib_get_netdev()
> helper at all.
> 
> > I sure can fix it and use ib_device_get_netdev api.
> >
> > Should I send it to the rdma-next on the top of the latest commit?
> 
> Yes, please.
> 

Hi Leon,

While preparing the patch, I realized that ib_device_get_netdev is not public
and it is defined in core_priv.h. Should I move the declaration and export the symbol?

Thanks

Re: Open-coded get_netdev implementation in MANA IB

[Leon Romanovsky]

On Wed, Jun 19, 2024 at 02:14:15PM +0000, Konstantin Taranov wrote:
> > Yes, the thing is that probably we were supposed to move to
> > ib_device_get_netdev() and don't invest time in mana_ib_get_netdev()
> > helper at all.
> > 
> > > I sure can fix it and use ib_device_get_netdev api.
> > >
> > > Should I send it to the rdma-next on the top of the latest commit?
> > 
> > Yes, please.
> > 
> 
> Hi Leon,
> 
> While preparing the patch, I realized that ib_device_get_netdev is not public
> and it is defined in core_priv.h. Should I move the declaration and export the symbol?

Let's keep it as is for now. I will try to return to this task after we
find a way to remove .get_netdev() callback from the drivers.

Sorry for wasting your time.

Thanks

> 
> Thanks