From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D58136E3B for ; Mon, 24 Jun 2024 13:23:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235399; cv=none; b=RAWGthNq7HIHRRqvWYCjGAgYELu/OG+SoIZ08zEkbIhOdufIOU+bylgCDiLtfw1hChnq6asNz1BJNOyC1AYnocZ1IWWQPxEkCCsA8EvyvD0KiZTweLYORC3cOqGxIl3Xq1+ne+bJQkue7rIGkg2K00ok+gu/SyooPVba/WUwMr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235399; c=relaxed/simple; bh=OIz5JHw9RZiPBx79UYece3LX1e6MEHOy0mCHXgYe3bU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rYX5oDhyhqK+LwiZtNPvRx1ubbSfx7GyEcxofP3WklqoNMFknYLJzJYdynQRK6y/+9dg3V15r5i2vZ5Hldjp9ex/G59ArloZL9vX1TkAbBJ5v+vLLiSb0rkGZfMUp6gMrWqBwkTgA5p6WWeKfUz7vGUYr10nD1mslpbS+bJK0TU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dk94aMVM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dk94aMVM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED4DFC2BBFC; Mon, 24 Jun 2024 13:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719235398; bh=OIz5JHw9RZiPBx79UYece3LX1e6MEHOy0mCHXgYe3bU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dk94aMVMeiVL19SEa2hkWQ24SVzIqHm/AowwLKjKqZsy0U0cB5ZZZMD7isAOM/O+3 pgYQkrsoFP6JtyU72qfFd6Xni4GcXuVEI1S5XLdtBGEi7cskHlgP6nC7PBAj5NTmjb /vFr1J5Z/hRRVyF/9MJjKNk6dT+jnFXQCCxIxFMNkbVKUjG3hi+AmzeVMFrX4gpuWE NFFfBwuYmujJJVrgsZ5+eKoaSpEKeZugLYVyu4YqxBvN8LvoNMq6IZI0o7a9BPhPgv 728/s5xv4tHKMAwKjNC21we6WIebbASaoKCwF6oypcrbpbYcGFsuVe2/gn92DEvRXU Xrm39ZztbHeQA== Date: Mon, 24 Jun 2024 16:23:13 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, Mark Zhang , Michael Guralnik , Or Har-Toov , Patrisious Haddad , Yishai Hadas Subject: Re: [PATCH rdma-rc 1/6] RDMA/cache: Release GID table even if leak is detected Message-ID: <20240624132313.GG29266@unreal> References: <20240621132139.GA4179191@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621132139.GA4179191@nvidia.com> On Fri, Jun 21, 2024 at 10:21:39AM -0300, Jason Gunthorpe wrote: > On Tue, May 28, 2024 at 03:52:51PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > When the table is released, we nullify pointer to GID table, it means > > that in case GID entry leak is detected, we will leak table too. > > > > Delete code that prevents table destruction. > > > > Fixes: b150c3862d21 ("IB/core: Introduce GID entry reference counts") > > Signed-off-by: Leon Romanovsky > > --- > > drivers/infiniband/core/cache.c | 13 ++++--------- > > 1 file changed, 4 insertions(+), 9 deletions(-) > > Since this is causing syzkaller failures and it really doesn't seem > like stable material I'm dropping it from the rc branch and putting it > in for-next. Lets see if we can fix the failures before the merge window. I don't see it in the for-next branch, can you please add it? Thanks > > Jason