linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Margolin <mrgolin@amazon.com>
To: <jgg@nvidia.com>, <leon@kernel.org>, <linux-rdma@vger.kernel.org>
Cc: <sleybo@amazon.com>, <matua@amazon.com>, <gal.pressman@linux.dev>,
	"Gal Pressman" <galpress@amazon.com>,
	Firas Jahjah <firasj@amazon.com>
Subject: [PATCH for-next 1/5] RDMA/efa: Use offset_in_page() function
Date: Mon, 24 Jun 2024 16:09:14 +0000	[thread overview]
Message-ID: <20240624160918.27060-2-mrgolin@amazon.com> (raw)
In-Reply-To: <20240624160918.27060-1-mrgolin@amazon.com>

From: Gal Pressman <galpress@amazon.com>

Use offset_in_page() instead of open-coding it.

Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Reviewed-by: Firas Jahjah <firasj@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Michael Margolin <mrgolin@amazon.com>
---
 drivers/infiniband/hw/efa/efa_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
index 8f7a13b79cdc..eee2ae215414 100644
--- a/drivers/infiniband/hw/efa/efa_verbs.c
+++ b/drivers/infiniband/hw/efa/efa_verbs.c
@@ -524,7 +524,7 @@ static int qp_mmap_entries_setup(struct efa_qp *qp,
 
 	address = dev->mem_bar_addr + resp->llq_desc_offset;
 	length = PAGE_ALIGN(params->sq_ring_size_in_bytes +
-			    (resp->llq_desc_offset & ~PAGE_MASK));
+			    offset_in_page(resp->llq_desc_offset));
 
 	qp->llq_desc_mmap_entry =
 		efa_user_mmap_entry_insert(&ucontext->ibucontext,
-- 
2.40.1


  reply	other threads:[~2024-06-24 16:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 16:09 [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Michael Margolin
2024-06-24 16:09 ` Michael Margolin [this message]
2024-06-25  6:32   ` [PATCH for-next 1/5] RDMA/efa: Use offset_in_page() function Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 2/5] RDMA/efa: Remove duplicate aenq enable macro Michael Margolin
2024-06-25  6:32   ` Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 3/5] RDMA/efa: Validate EQ array out of bounds reach Michael Margolin
2024-06-25  6:33   ` Gal Pressman
2024-06-25 11:28     ` Margolin, Michael
2024-06-25 14:16       ` Leon Romanovsky
2024-06-24 16:09 ` [PATCH for-next 4/5] RDMA/efa: Move type conversion helpers to efa.h Michael Margolin
2024-06-25  6:33   ` Gal Pressman
2024-06-25 11:21     ` Margolin, Michael
2024-06-25 14:19       ` Leon Romanovsky
2024-06-24 16:09 ` [PATCH for-next 5/5] RDMA/efa: Align private func names to a single convention Michael Margolin
2024-06-26 15:38   ` Jason Gunthorpe
2024-06-27 16:57     ` Margolin, Michael
2024-06-27 18:43       ` Leon Romanovsky
2024-06-28 14:27         ` Jason Gunthorpe
2024-06-26 17:55 ` [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624160918.27060-2-mrgolin@amazon.com \
    --to=mrgolin@amazon.com \
    --cc=firasj@amazon.com \
    --cc=gal.pressman@linux.dev \
    --cc=galpress@amazon.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    --cc=sleybo@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).