From: Leon Romanovsky <leon@kernel.org>
To: "Margolin, Michael" <mrgolin@amazon.com>
Cc: Gal Pressman <gal.pressman@linux.dev>,
jgg@nvidia.com, linux-rdma@vger.kernel.org, sleybo@amazon.com,
matua@amazon.com, Firas Jahjah <firasj@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next 4/5] RDMA/efa: Move type conversion helpers to efa.h
Date: Tue, 25 Jun 2024 17:19:21 +0300 [thread overview]
Message-ID: <20240625141921.GL29266@unreal> (raw)
In-Reply-To: <99b2acde-bb35-4de9-9d1f-d52e69e81bce@amazon.com>
On Tue, Jun 25, 2024 at 02:21:39PM +0300, Margolin, Michael wrote:
> On 6/25/2024 9:33 AM, Gal Pressman wrote
>
> > On 24/06/2024 19:09, Michael Margolin wrote:
> > > Move ib_ to efa_ types conversion functions to have them near the types
> > > definitions and to reduce code in efa_verbs.c.
> > >
> > > Reviewed-by: Firas Jahjah <firasj@amazon.com>
> > > Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> > > Signed-off-by: Michael Margolin <mrgolin@amazon.com>
> > The idea was to not expose these functions in the h file as they are not
> > used outside of efa_verbs.c.
>
> I know but it's a driver internal header and it also makes sense to have the
> cast from the base type near the definition.
We put in header file things which are used in multiple files. It is not
the case here. Let's try to avoid code churn without real gain behind it.
Thanks
>
> Michael
>
next prev parent reply other threads:[~2024-06-25 14:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 16:09 [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Michael Margolin
2024-06-24 16:09 ` [PATCH for-next 1/5] RDMA/efa: Use offset_in_page() function Michael Margolin
2024-06-25 6:32 ` Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 2/5] RDMA/efa: Remove duplicate aenq enable macro Michael Margolin
2024-06-25 6:32 ` Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 3/5] RDMA/efa: Validate EQ array out of bounds reach Michael Margolin
2024-06-25 6:33 ` Gal Pressman
2024-06-25 11:28 ` Margolin, Michael
2024-06-25 14:16 ` Leon Romanovsky
2024-06-24 16:09 ` [PATCH for-next 4/5] RDMA/efa: Move type conversion helpers to efa.h Michael Margolin
2024-06-25 6:33 ` Gal Pressman
2024-06-25 11:21 ` Margolin, Michael
2024-06-25 14:19 ` Leon Romanovsky [this message]
2024-06-24 16:09 ` [PATCH for-next 5/5] RDMA/efa: Align private func names to a single convention Michael Margolin
2024-06-26 15:38 ` Jason Gunthorpe
2024-06-27 16:57 ` Margolin, Michael
2024-06-27 18:43 ` Leon Romanovsky
2024-06-28 14:27 ` Jason Gunthorpe
2024-06-26 17:55 ` [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625141921.GL29266@unreal \
--to=leon@kernel.org \
--cc=firasj@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).