Re: [PATCH rdma-next v1 1/2] RDMA: Pass entire uverbs attr bundle to create cq function

[Jason Gunthorpe <jgg@nvidia.com>]

On Mon, Jun 24, 2024 at 07:00:10PM +0300, Leon Romanovsky wrote:
> From: Akiva Goldberger <agoldberger@nvidia.com>
> 
> Changes the create_cq verb signature by sending the entire uverbs attr
> bundle as a parameter. This allows drivers to send driver specific attrs
> through ioctl for the create_cq verb and access them in their driver
> specific code.
> 
> Also adds a new enum value for driver specific ioctl attributes for
> methods already supporting UHW.

I was going to pick this up but it doesn't compile:

../drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c:156:15: error: incompatible function pointer types initializing 'int (*)(struct ib_cq *, const struct ib_cq_init_attr *, struct uverbs_attr_bundle *)' with an expression of type 'int (struct ib_cq *, const struct ib_cq_init_attr *, struct ib_udata *)' [-Wincompatible-function-pointer-types]
  156 |         .create_cq = pvrdma_create_cq,
      |                      ^~~~~~~~~~~~~~~~
../drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c:814:46: warning: shift count >= width of type [-Wshift-count-overflow]
  814 |         ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
      |                                                     ^~~~~~~~~~~~~~~~
../include/linux/dma-mapping.h:77:54: note: expanded from macro 'DMA_BIT_MASK'
   77 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
      |                                                      ^ ~~~
1 warning and 1 error generated.

Didn't get all the drivers? Don't have all the drivers turned on in
your kconfig?

Jason