From: Leon Romanovsky <leon@kernel.org>
To: "Margolin, Michael" <mrgolin@amazon.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
linux-rdma@vger.kernel.org, sleybo@amazon.com, matua@amazon.com,
gal.pressman@linux.dev, Firas Jahjah <firasj@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next 5/5] RDMA/efa: Align private func names to a single convention
Date: Thu, 27 Jun 2024 21:43:20 +0300 [thread overview]
Message-ID: <20240627184320.GT29266@unreal> (raw)
In-Reply-To: <6310c5d0-e72d-4b4a-9b78-b19b622fdb92@amazon.com>
On Thu, Jun 27, 2024 at 07:57:17PM +0300, Margolin, Michael wrote:
>
> On 6/26/2024 6:38 PM, Jason Gunthorpe wrote:
> > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> >
> >
> >
> > On Mon, Jun 24, 2024 at 04:09:18PM +0000, Michael Margolin wrote:
> > > Name functions that aren't exposed outside of a file with '_' prefix and
> > > make sure that all verbs ops' implementations are named according to the
> > > op name with an additional 'efa_' prefix.
> > That isn't the kernel convention, please don't use _ like this
> >
> > Jason
>
> AFAIK there is no single kernel convention for static functions naming and
> it also seems that the underscore prefix isn't rare in the subsystem.
Underscore at the beginning of the function name is a common practice
to mark that function as locked variant.
Thanks
next prev parent reply other threads:[~2024-06-27 18:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 16:09 [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Michael Margolin
2024-06-24 16:09 ` [PATCH for-next 1/5] RDMA/efa: Use offset_in_page() function Michael Margolin
2024-06-25 6:32 ` Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 2/5] RDMA/efa: Remove duplicate aenq enable macro Michael Margolin
2024-06-25 6:32 ` Gal Pressman
2024-06-24 16:09 ` [PATCH for-next 3/5] RDMA/efa: Validate EQ array out of bounds reach Michael Margolin
2024-06-25 6:33 ` Gal Pressman
2024-06-25 11:28 ` Margolin, Michael
2024-06-25 14:16 ` Leon Romanovsky
2024-06-24 16:09 ` [PATCH for-next 4/5] RDMA/efa: Move type conversion helpers to efa.h Michael Margolin
2024-06-25 6:33 ` Gal Pressman
2024-06-25 11:21 ` Margolin, Michael
2024-06-25 14:19 ` Leon Romanovsky
2024-06-24 16:09 ` [PATCH for-next 5/5] RDMA/efa: Align private func names to a single convention Michael Margolin
2024-06-26 15:38 ` Jason Gunthorpe
2024-06-27 16:57 ` Margolin, Michael
2024-06-27 18:43 ` Leon Romanovsky [this message]
2024-06-28 14:27 ` Jason Gunthorpe
2024-06-26 17:55 ` [PATCH for-next 0/5] RDMA/efa: Cleanups and minor improvements Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627184320.GT29266@unreal \
--to=leon@kernel.org \
--cc=firasj@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).