From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A216D1C9DDA for ; Wed, 7 Aug 2024 08:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723020239; cv=none; b=sKEWdVFPv8yHHOWP2IfOGnoyNR0m+/vKjrDtzZUjycRtHqcf5iJINvzORCbcmaFeHzFC/c6iMPQ+g0rApLv8XyFe390C69PalUmJlpDC1CCWShAjTda3lm0VD8hNzWDNbur6rxpk7izDKyCNyOlfmNIFRCh/wnpDo4qSXylc1/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723020239; c=relaxed/simple; bh=4BstarA/azTj0MQhXEHPNbE5+HYWrDilUXJZYFWQ+iw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=WtCmJ7GQlRL8Ki3IobwCjDPgxGlcu45QFf+RLju4TCd3FIgsZRWqvKP3qPzGD/2bpzyVgJKfI2tWisufFFDwn6kAlB5h0SOpTvD+6bt0/5rTp79+ei4QSi4+uZVcn6yn8GU6SoQtv8SkrhNl4BP1UXRG0CcvCAvXrGzSlOH6hpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=OQ/7Q8u4; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="OQ/7Q8u4" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-70943713472so642210a34.2 for ; Wed, 07 Aug 2024 01:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1723020237; x=1723625037; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=Iw7Tv+YETDv5W6d9wVYOGpd/7bHckBYfrgRk1yNks+I=; b=OQ/7Q8u4/rKgMnmfsm92qJn7lrBnkLHDS7V3j1hcMV81mDoVvMWsnxQROcu0pJMJGj EI08rcLDW3Eyfc3NPVQZBrC8vDKHYTY1tWy6Hp7oC1MNfThqO9lHJajnYRIHx55rVXwx zg6xupztTNS25AZY12LDyIRaWcNlBIeVMGs2sfP4hqj7E9PUgypFUBQPatUkQzlNVE5W lNuNBNZAj5dKHPLNoR67BDKudufTdASj2yVN3ShiXyLPuEAxPtWmBgt6Aahj5fsSuY2l j6F0rq+zMhRNHWg46KQmQl2nGVpmMdJ5QGPAg1aRgHR8A9/ihe9zinHGNO/hs7I9Kx6N 6TyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723020237; x=1723625037; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Iw7Tv+YETDv5W6d9wVYOGpd/7bHckBYfrgRk1yNks+I=; b=IUunKzwY3V2Tt6v3SErTttPiD28C1HufiCpvwbfZJYFk1Lo/pj9uneAYYt63zPKYn+ nV3WL5fujr4KkhO3BbY8V01GSMxnwqDS3/WtfDH9k/UD2vZ6+leCvcmA5k5pdUvmbhe1 n/++JjZYAI8M4dDAuSJQ1ZkEqOZzf0fELY0QzSUDeNsDkxvZLviVA2FTJqKHQkEJS1a1 Kk9iaE5qk5DZNt4iSWNHh9xmBcfLMg+OxgbbXZcDLBOmgbNdAx1Esp/t9HsGQsdmDL5g nXdIfbECf2yqR3r44x6Yxd8FtcfAvSOlyiuMvLO2rYWiLTXoidegJTVe6flPrCjMh4AA R46g== X-Forwarded-Encrypted: i=1; AJvYcCUlUc/qOzdXUZH0M2FCAZQwGFjILMJ2mNDzB7Gzixdj5SXg/N+VEVd5sGlH/WKXxozccXAd0KixcTuKO4drTdWplCYy8ZI9ejMi+g== X-Gm-Message-State: AOJu0Yyh+yRqwdVjzqNMCNEwbWeNAy469OB5YbrL8L3kzzcaqCSOLR6R S8FEwgmyexnPOtMwF3Jx+MUa2qKBv+A/QYz/13xuQ3csKUXLow8f1vWIt5zXTPY= X-Google-Smtp-Source: AGHT+IHGDJwgvu27ZoxkF/Iz1RMQROmHIKs8TmuQAxLdh09B6CWq3+c9Jjh5o5EFESeTZQUuMmrUsQ== X-Received: by 2002:a05:6358:418f:b0:1ac:660a:8a69 with SMTP id e5c5f4694b2df-1af3baf62a6mr2337848555d.18.1723020236454; Wed, 07 Aug 2024 01:43:56 -0700 (PDT) Received: from dev-mattc2.dev.purestorage.com ([208.88.159.128]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-7b7654bf852sm6742435a12.90.2024.08.07.01.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 01:43:55 -0700 (PDT) From: Matthew W Carlis To: helgaas@kernel.org Cc: alex.williamson@redhat.com, bhelgaas@google.com, davem@davemloft.net, david.abdurachmanov@gmail.com, edumazet@google.com, kuba@kernel.org, leon@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lukas@wunner.de, macro@orcam.me.uk, mahesh@linux.ibm.com, mattc@purestorage.com, mika.westerberg@linux.intel.com, netdev@vger.kernel.org, npiggin@gmail.com, oohall@gmail.com, pabeni@redhat.com, pali@kernel.org, saeedm@nvidia.com, sr@denx.de, wilson@tuliptree.org Subject: PCI: Work around PCIe link training failures Date: Wed, 7 Aug 2024 02:43:48 -0600 Message-Id: <20240807084348.12304-1-mattc@purestorage.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240806193622.GA74589@bhelgaas> References: <20240806193622.GA74589@bhelgaas> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: On Tues, 06 Aug 2024 Bjorn Helgaas wrote: > it does seem like this series made wASMedia ASM2824 work better but > caused regressions elsewhere, so maybe we just need to accept that > ASM2824 is slightly broken and doesn't work as well as it should. One of my colleagues challenged me to provide a more concrete example where the change will cause problems. One such configuration would be not implementing the Power Controller Control in the Slot Capabilities Register. Then, Powering off the slot via out-of-band interfaces would result in the kernel forcing the DSP to Gen1 100% of the time as far as I can tell. The aspect of this force to Gen1 that is the most concerning to my team is that it isn't cleaned up even if we replaced the EP with some other EP. I was curious about the PCIe devices mentioned in the commit because I look at crazy malfunctioning devices too often so I pasted the following: "Delock Riser Card PCI Expres 41433" into Google. I'm not really a physical layer guy, but is it possible that the reported issue be due to signal integrity? I'm not sure if sending PCIe over a USB cable is "reliable". I've never worked with an ASMedia switch and don't have a reliable way to reproduce anything like the interaction between the two device at hand. As much as I hate to make the request my thinking is that the patch should be reverted until there is a solution that doesn't leave the link forced to Gen1 forever for every EP thereafter. - Matt