Re: [PATCH] RDMA/efa: Fix node guid compiler warning

Jason Gunthorpe
2024-10-02T13:04:31Z

On Wed, Oct 02, 2024 at 03:30:30PM +0300, Margolin, Michael wrote:

> > > > > Actually that's wrong, the device always sets guid in BE order so no
> > > > > swap is needed in the driver in any case.

> > > > They you just mark it as _be64 in the struct and there is no reason
> > > > for the __force ?
> > > >
> > > That's probably the most correct way but I prefer to avoid introducing
> > > kernel specific types in a shared interface file.
> > ?
> >
> > what is a "shared interface file" ?
> >
> > That doesn't sound like a linux thing
>
> Nothing particularly related to linux, just a common practice of having the
> same interface on both sides (driver and device in this case).

Well, you still have to use correct types in the linux headers and
work that out somehow

Jason