Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: yishaih@nvidia.com, jgg@ziepe.ca, leon@kernel.org,
	linux-rdma@vger.kernel.org
Cc: Zhu Yanjun <yanjun.zhu@linux.dev>
Subject: [PATCH 1/1] RDMA/mlx4: Use IB get_netdev functions and remove get_netdev callback
Date: Thu, 31 Oct 2024 08:39:14 +0100	[thread overview]
Message-ID: <20241031073914.2368421-1-yanjun.zhu@linux.dev> (raw)

In the commit 8d159eb2117b ("RDMA/mlx5: Use IB set_netdev and get_netdev
functions") removed the get_netdev callback from
mlx5_ib_dev_common_roce_ops, in mlx4, get_netdev callback should also
be removed.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
compile successfully only
---
---
 drivers/infiniband/hw/mlx4/main.c | 35 -------------------------------
 1 file changed, 35 deletions(-)

diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index 529db874d67c..cf34d92de7b1 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -123,40 +123,6 @@ static int num_ib_ports(struct mlx4_dev *dev)
 	return ib_ports;
 }
 
-static struct net_device *mlx4_ib_get_netdev(struct ib_device *device,
-					     u32 port_num)
-{
-	struct mlx4_ib_dev *ibdev = to_mdev(device);
-	struct net_device *dev, *ret = NULL;
-
-	rcu_read_lock();
-	for_each_netdev_rcu(&init_net, dev) {
-		if (dev->dev.parent != ibdev->ib_dev.dev.parent ||
-		    dev->dev_port + 1 != port_num)
-			continue;
-
-		if (mlx4_is_bonded(ibdev->dev)) {
-			struct net_device *upper;
-
-			upper = netdev_master_upper_dev_get_rcu(dev);
-			if (upper) {
-				struct net_device *active;
-
-				active = bond_option_active_slave_get_rcu(netdev_priv(upper));
-				if (active)
-					dev = active;
-			}
-		}
-
-		dev_hold(dev);
-		ret = dev;
-		break;
-	}
-
-	rcu_read_unlock();
-	return ret;
-}
-
 static int mlx4_ib_update_gids_v1(struct gid_entry *gids,
 				  struct mlx4_ib_dev *ibdev,
 				  u32 port_num)
@@ -2544,7 +2510,6 @@ static const struct ib_device_ops mlx4_ib_dev_ops = {
 	.get_dev_fw_str = get_fw_ver_str,
 	.get_dma_mr = mlx4_ib_get_dma_mr,
 	.get_link_layer = mlx4_ib_port_link_layer,
-	.get_netdev = mlx4_ib_get_netdev,
 	.get_port_immutable = mlx4_port_immutable,
 	.map_mr_sg = mlx4_ib_map_mr_sg,
 	.mmap = mlx4_ib_mmap,
-- 
2.34.1


             reply	other threads:[~2024-10-31  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  7:39 Zhu Yanjun [this message]
2024-10-31  8:18 ` [PATCH 1/1] RDMA/mlx4: Use IB get_netdev functions and remove get_netdev callback Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241031073914.2368421-1-yanjun.zhu@linux.dev \
    --to=yanjun.zhu@linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox