From: Jason Gunthorpe <jgg@ziepe.ca>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,
linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com,
Kashyap Desai <kashyap.desai@broadcom.com>
Subject: Re: [PATCH for-rc 4/5] RDMA/bnxt_re: Fix error recovery sequence
Date: Wed, 11 Dec 2024 11:56:10 -0400 [thread overview]
Message-ID: <20241211155610.GL1888283@ziepe.ca> (raw)
In-Reply-To: <CA+sbYW0n5CPupxByysd7Dc9=QLQm33ivC1YH5T2UbvG6MBVymg@mail.gmail.com>
On Wed, Dec 11, 2024 at 11:33:38AM +0530, Selvin Xavier wrote:
> ib_unregister will trigger the destroy_qp (at least QP1) and
> destroy_cqs. Those verbs will be trying to issue the FW command and
> we are trying to prevent sending it to FW here. We need a check
> here in the common path to avoid sending any commands and i dont see
> a way to handle this otherwise. Current check has a bug where the
> return code check was not correct and we ended up sending some of
> the commands that eventually timeout.
>
> Just to add, We have similar implementation in our L2 driver also,
> which we were trying to replicate using
> bnxt_re data structures.
Doesn't that suggest this is layered wrong? Shouldn't these tests be
inside the shared command submission code?
Jason
next prev parent reply other threads:[~2024-12-11 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 7:54 [PATCH for-rc 0/5] RDMA/bnxt_re: Bug fixes Kalesh AP
2024-12-04 7:54 ` [PATCH for-rc 1/5] RDMA/bnxt_re: Fix max SGEs for the Work Request Kalesh AP
2024-12-04 7:54 ` [PATCH for-rc 2/5] RDMA/bnxt_re: Avoid initializing the software queue for user queues Kalesh AP
2024-12-04 7:54 ` [PATCH for-rc 3/5] RDMA/bnxt_re: Avoid sending the modify QP workaround for latest adapters Kalesh AP
2024-12-04 7:54 ` [PATCH for-rc 4/5] RDMA/bnxt_re: Fix error recovery sequence Kalesh AP
2024-12-05 9:07 ` Leon Romanovsky
2024-12-05 9:31 ` Kalesh Anakkur Purayil
2024-12-05 11:38 ` Leon Romanovsky
2024-12-09 4:43 ` Selvin Xavier
2024-12-10 11:48 ` Leon Romanovsky
2024-12-11 6:03 ` Selvin Xavier
2024-12-11 15:56 ` Jason Gunthorpe [this message]
2024-12-11 17:06 ` Selvin Xavier
2024-12-17 5:23 ` Kalesh Anakkur Purayil
2024-12-19 11:46 ` Leon Romanovsky
2024-12-20 5:53 ` Kalesh Anakkur Purayil
2024-12-04 7:54 ` [PATCH for-rc 5/5] RDMA/bnxt_re: Fix bnxt_re_destroy_qp() Kalesh AP
2024-12-05 9:08 ` [PATCH for-rc 0/5] RDMA/bnxt_re: Bug fixes Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211155610.GL1888283@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andrew.gospodarek@broadcom.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kashyap.desai@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox