public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Zhu Yanjun <yanjun.zhu@linux.dev>
Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/1] RDMA/rxe: Change the return type from int to bool
Date: Tue, 14 Jan 2025 13:47:25 +0200	[thread overview]
Message-ID: <20250114114725.GH3146852@unreal> (raw)
In-Reply-To: <20250111102758.308502-1-yanjun.zhu@linux.dev>

On Sat, Jan 11, 2025 at 11:27:58AM +0100, Zhu Yanjun wrote:
> The return type of the functions queue_full and queue_empty should be
> bool.
> 
> No functional changes.
> 
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
>  drivers/infiniband/sw/rxe/rxe_cq.c    | 2 +-
>  drivers/infiniband/sw/rxe/rxe_queue.h | 4 ++--
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 6 +++---
>  3 files changed, 6 insertions(+), 6 deletions(-)

Let's not do change just for the sake of change.
This standalone patch has zero effect on the code, both from functionality
and readability point of views.

Thanks

      parent reply	other threads:[~2025-01-14 11:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-11 10:27 [PATCH 1/1] RDMA/rxe: Change the return type from int to bool Zhu Yanjun
2025-01-13  0:53 ` Zhijian Li (Fujitsu)
2025-01-14  9:22   ` Zhu Yanjun
2025-01-14 11:47 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250114114725.GH3146852@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yanjun.zhu@linux.dev \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox