Re: [PATCH for-next] RDMA/bnxt_re: Congestion control settings using debugfs hook

[Leon Romanovsky <leon@kernel.org>]

On Sun, Jan 19, 2025 at 04:01:55PM +0530, Selvin Xavier wrote:
> On Sun, Jan 19, 2025 at 3:27 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Fri, Jan 17, 2025 at 08:29:04PM -0800, Selvin Xavier wrote:
> > > Implements routines to set and get different settings  of
> > > the congestion control. This will enable the users to modify
> > > the settings according to their network.
> > >
> > > Currently supporting only GEN 0 version of the parameters.
> > > Reading these files queries the firmware and report the values
> > > currently programmed. Writing to the files sends commands that
> > > update the congestion control settings.
> > >
> > > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> > > ---
> > >  drivers/infiniband/hw/bnxt_re/bnxt_re.h |   2 +
> > >  drivers/infiniband/hw/bnxt_re/debugfs.c | 215 +++++++++++++++++++++++++++++++-
> > >  drivers/infiniband/hw/bnxt_re/debugfs.h |  15 +++
> > >  3 files changed, 231 insertions(+), 1 deletion(-)
> >
> > <...>
> >
> > > +static const char * const bnxt_re_cc_gen0_name[] = {
> > > +     "enable_cc",
> > > +     "g",
> >
> > ????
> It is the "running avg. weight" used by Congestion control algo in HW.
> It is referred as "g" in the parameters and the FW command. So used
> the same name for the debugfs file.

At the end, it is your debugfs for your customers. IMHO, it doesn't look
nice to them.

Thanks