From: Leon Romanovsky <leon@kernel.org>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org,
andrew.gospodarek@broadcom.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH for-next v2] RDMA/bnxt_re: Congestion control settings using debugfs hook
Date: Mon, 3 Feb 2025 14:03:14 +0200 [thread overview]
Message-ID: <20250203120314.GF74886@unreal> (raw)
In-Reply-To: <1737301535-6599-1-git-send-email-selvin.xavier@broadcom.com>
On Sun, Jan 19, 2025 at 07:45:35AM -0800, Selvin Xavier wrote:
> Implements routines to set and get different settings of
> the congestion control. This will enable the users to modify
> the settings according to their network.
>
> Currently supporting only GEN 0 version of the parameters.
> Reading these files queries the firmware and report the values
> currently programmed. Writing to the files sends commands that
> update the congestion control settings
>
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
> v1 -> v2:
> Addressed Leon's comments
> - rename debugfs file "g" to "run_avg_weight_g"
> - Fix the indentation errors
> - Remove the unnecessary error message during the read entry point
> - Fix the return value
>
> drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 +
> drivers/infiniband/hw/bnxt_re/debugfs.c | 212 +++++++++++++++++++++++++++++++-
> drivers/infiniband/hw/bnxt_re/debugfs.h | 15 +++
> 3 files changed, 228 insertions(+), 1 deletion(-)
We don't have strong policy of what can/can't be in debugfs, so let's
take it.
Thanks
next prev parent reply other threads:[~2025-02-03 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 15:45 [PATCH for-next v2] RDMA/bnxt_re: Congestion control settings using debugfs hook Selvin Xavier
2025-01-20 16:40 ` Jason Gunthorpe
2025-01-21 10:40 ` Selvin Xavier
2025-01-21 15:31 ` Jason Gunthorpe
2025-01-22 8:09 ` Selvin Xavier
2025-01-22 15:22 ` Jason Gunthorpe
2025-01-23 5:20 ` Selvin Xavier
2025-02-03 12:02 ` Leon Romanovsky
2025-02-03 12:03 ` Leon Romanovsky [this message]
2025-02-08 9:19 ` Chengchang Tang
2025-02-08 13:14 ` Selvin Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203120314.GF74886@unreal \
--to=leon@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox