From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, shirazsaleem@microsoft.com,
sharmaajay@microsoft.com, longli@microsoft.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Add port statistics support
Date: Thu, 6 Feb 2025 11:08:28 +0200 [thread overview]
Message-ID: <20250206090828.GP74886@unreal> (raw)
In-Reply-To: <1738751527-15517-1-git-send-email-kotaranov@linux.microsoft.com>
On Wed, Feb 05, 2025 at 02:32:07AM -0800, Konstantin Taranov wrote:
> From: Shiraz Saleem <shirazsaleem@microsoft.com>
>
> Implement alloc_hw_port_stats and get_hw_stats APIs to support querying
> MANA VF port level statistics from rdma stat tool.
>
> Example output from rdma stat tool:
>
> $rdma statistic show link mana_0/1 -p
> link mana_0/1
> requester_timeout 45
> requester_oos_nak 0
> requester_rnr_nak 0
> responder_rnr_nak 0
> responder_oos 0
> responder_dup_request 0
> requester_implicit_nak 0
> requester_readresp_psn_mismatch 0
> nak_inv_req 0
> nak_access_error 0
> nak_opp_error 0
> nak_inv_read 0
> responder_local_len_error 0
> requestor_local_prot_error 0
> responder_rem_access_error 0
> responder_local_qp_error 0
> responder_malformed_wqe 0
> general_hw_error 6
> requester_rnr_nak_retries_exceeded 0
> requester_retries_exceeded 5
> total_fatal_error 6
> received_cnps 0
> num_qps_congested 0
> rate_inc_events 0
> num_qps_recovered 0
> current_rate 100000
>
> Signed-off-by: Shiraz Saleem <shirazsaleem@microsoft.com>
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> ---
> drivers/infiniband/hw/mana/Makefile | 2 +-
> drivers/infiniband/hw/mana/counters.c | 105 ++++++++++++++++++++++++++
> drivers/infiniband/hw/mana/counters.h | 44 +++++++++++
> drivers/infiniband/hw/mana/device.c | 7 ++
> drivers/infiniband/hw/mana/mana_ib.h | 61 ++++++++++++---
> 5 files changed, 206 insertions(+), 13 deletions(-)
> create mode 100644 drivers/infiniband/hw/mana/counters.c
> create mode 100644 drivers/infiniband/hw/mana/counters.h
<...>
> enum mana_ib_command_code {
> - MANA_IB_GET_ADAPTER_CAP = 0x30001,
> - MANA_IB_CREATE_ADAPTER = 0x30002,
> - MANA_IB_DESTROY_ADAPTER = 0x30003,
> - MANA_IB_CONFIG_IP_ADDR = 0x30004,
> - MANA_IB_CONFIG_MAC_ADDR = 0x30005,
> - MANA_IB_CREATE_UD_QP = 0x30006,
> - MANA_IB_DESTROY_UD_QP = 0x30007,
> - MANA_IB_CREATE_CQ = 0x30008,
> - MANA_IB_DESTROY_CQ = 0x30009,
> - MANA_IB_CREATE_RC_QP = 0x3000a,
> - MANA_IB_DESTROY_RC_QP = 0x3000b,
> - MANA_IB_SET_QP_STATE = 0x3000d,
> + MANA_IB_GET_ADAPTER_CAP = 0x30001,
> + MANA_IB_CREATE_ADAPTER = 0x30002,
> + MANA_IB_DESTROY_ADAPTER = 0x30003,
> + MANA_IB_CONFIG_IP_ADDR = 0x30004,
> + MANA_IB_CONFIG_MAC_ADDR = 0x30005,
> + MANA_IB_CREATE_UD_QP = 0x30006,
> + MANA_IB_DESTROY_UD_QP = 0x30007,
> + MANA_IB_CREATE_CQ = 0x30008,
> + MANA_IB_DESTROY_CQ = 0x30009,
> + MANA_IB_CREATE_RC_QP = 0x3000a,
> + MANA_IB_DESTROY_RC_QP = 0x3000b,
> + MANA_IB_SET_QP_STATE = 0x3000d,
> + MANA_IB_QUERY_VF_COUNTERS = 0x30022,
> };
Please stop to do vertical alignment. We don't need this churn.
I fixed it locally.
Thanks
next prev parent reply other threads:[~2025-02-06 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 10:32 [PATCH rdma-next 1/1] RDMA/mana_ib: Add port statistics support Konstantin Taranov
2025-02-05 19:08 ` Long Li
2025-02-06 9:08 ` Leon Romanovsky [this message]
2025-02-06 9:12 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206090828.GP74886@unreal \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
--cc=shirazsaleem@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox