From: Jason Gunthorpe <jgg@nvidia.com>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
andrew.gospodarek@broadcom.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH rdma-rc 3/4] RDMA/bnxt_re: Fix issue in the unload path
Date: Tue, 25 Feb 2025 14:42:49 -0400 [thread overview]
Message-ID: <20250225184249.GA609904@nvidia.com> (raw)
In-Reply-To: <1738657285-23968-4-git-send-email-selvin.xavier@broadcom.com>
On Tue, Feb 04, 2025 at 12:21:24AM -0800, Selvin Xavier wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> The cited comment removed the netdev notifier register call
> from the driver. But, it did not remove the cleanup code from
> the unload path. As a result, driver unload is not clean and
> resulted in undesired behaviour.
Please don't use vauge generic commit titles:
RDMA/bnxt_re: Fix issue in the unload path
Be specific and exact, there are several cases like this in this
series and I'm actively wondering if Linus will object to this for rc
patches.
RDMA/bnxt_re: Fix missed call to ib_unregister_device()
Since rdev->nb.notifier_call is always NULL the actual work in
bnxt_re_remove_device() was skipped
Jason
next prev parent reply other threads:[~2025-02-25 18:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 8:21 [PATCH rdma-rc 0/4] RDMA/bnxt_re: Bug fixes for 6.14 Selvin Xavier
2025-02-04 8:21 ` [PATCH rdma-rc 1/4] RDMA/bnxt_re: Fix an issue in bnxt_re_async_notifier Selvin Xavier
2025-02-04 8:21 ` [PATCH rdma-rc 2/4] RDMA/bnxt_re: Add sanity checks on rdev validity Selvin Xavier
2025-02-04 11:44 ` Leon Romanovsky
2025-02-04 16:40 ` Kalesh Anakkur Purayil
2025-02-05 7:17 ` Leon Romanovsky
2025-02-05 8:24 ` Kalesh Anakkur Purayil
2025-02-05 9:52 ` Leon Romanovsky
2025-02-05 16:15 ` Kalesh Anakkur Purayil
2025-02-09 17:18 ` Selvin Xavier
2025-02-09 20:05 ` Leon Romanovsky
2025-02-05 14:47 ` Jason Gunthorpe
2025-02-05 16:20 ` Kalesh Anakkur Purayil
2025-02-04 8:21 ` [PATCH rdma-rc 3/4] RDMA/bnxt_re: Fix issue in the unload path Selvin Xavier
2025-02-25 18:42 ` Jason Gunthorpe [this message]
2025-02-26 5:39 ` Selvin Xavier
2025-02-04 8:21 ` [PATCH rdma-rc 4/4] RDMA/bnxt_re: Fix the statistics for Gen P7 VF Selvin Xavier
2025-02-10 8:40 ` [PATCH rdma-rc 0/4] RDMA/bnxt_re: Bug fixes for 6.14 Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225184249.GA609904@nvidia.com \
--to=jgg@nvidia.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox