From: Tariq Toukan <tariqt@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>
Cc: Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Moshe Shemesh <moshe@nvidia.com>,
Shahar Shitrit <shshitrit@nvidia.com>
Subject: [PATCH net-next 1/4] net/mlx5: Avoid report two health errors on same syndrome
Date: Wed, 26 Feb 2025 14:25:40 +0200 [thread overview]
Message-ID: <20250226122543.147594-2-tariqt@nvidia.com> (raw)
In-Reply-To: <20250226122543.147594-1-tariqt@nvidia.com>
From: Moshe Shemesh <moshe@nvidia.com>
In case health counter has not increased for few polling intervals, miss
counter will reach max misses threshold and health report will be
triggered for FW health reporter. In case syndrome found on same health
poll another health report will be triggered.
Avoid two health reports on same syndrome by marking this syndrome as
already known.
Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index a6329ca2d9bf..52c8035547be 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
@@ -799,6 +799,7 @@ static void poll_health(struct timer_list *t)
health->prev = count;
if (health->miss_counter == MAX_MISSES) {
mlx5_core_err(dev, "device's health compromised - reached miss count\n");
+ health->synd = ioread8(&h->synd);
print_health_info(dev);
queue_work(health->wq, &health->report_work);
}
--
2.45.0
next prev parent reply other threads:[~2025-02-26 12:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 12:25 [PATCH net-next 0/4] mlx5: Trust lockdown health syndrome Tariq Toukan
2025-02-26 12:25 ` Tariq Toukan [this message]
2025-02-26 12:57 ` [PATCH net-next 1/4] net/mlx5: Avoid report two health errors on same syndrome Kalesh Anakkur Purayil
2025-02-26 12:25 ` [PATCH net-next 2/4] net/mlx5: Log health buffer data on any syndrome Tariq Toukan
2025-02-26 12:57 ` Kalesh Anakkur Purayil
2025-02-26 12:25 ` [PATCH net-next 3/4] net/mlx5: Expose crr in health buffer Tariq Toukan
2025-02-27 5:56 ` Michal Swiatkowski
2025-02-27 10:34 ` Tariq Toukan
2025-02-26 12:25 ` [PATCH net-next 4/4] net/mlx5: Add trust lockdown error to health syndrome print function Tariq Toukan
2025-02-26 12:56 ` Kalesh Anakkur Purayil
2025-02-28 9:00 ` [PATCH net-next 0/4] mlx5: Trust lockdown health syndrome patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226122543.147594-2-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shshitrit@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox