From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Shahar Shitrit <shshitrit@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>
Subject: Re: [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when auto-negotiation is off
Date: Fri, 28 Feb 2025 15:54:37 -0800 [thread overview]
Message-ID: <20250228155437.0a6ec42a@kernel.org> (raw)
In-Reply-To: <20250226114752.104838-4-tariqt@nvidia.com>
On Wed, 26 Feb 2025 13:47:49 +0200 Tariq Toukan wrote:
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 84833cca29fe..49d50afb102c 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -2192,6 +2192,8 @@ enum ethtool_link_mode_bit_indices {
> #define SPEED_800000 800000
>
> #define SPEED_UNKNOWN -1
> +#define LANES_UNKNOWN 0
> +#define MAX_LANES 8
Almost missed this.
Any reason you're adding to the uAPI header?
Just because that's where SPEED_UNKNOWN is defined?
IIRC lanes are only reported via netlink, so we don't need
to worry about sharing unspecified values with user space.
Stuff added to the uAPI header is harder to clean up,
if you don't have a strong reason I think we should move
these defines to the kernel header.
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-28 23:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 11:47 [PATCH net-next 0/6] mlx5 misc enhancements 2025-02-26 Tariq Toukan
2025-02-26 11:47 ` [PATCH net-next 1/6] net/mlx5: Relocate function declarations from port.h to mlx5_core.h Tariq Toukan
2025-02-26 11:47 ` [PATCH net-next 2/6] net/mlx5: Refactor link speed handling with mlx5_link_info struct Tariq Toukan
2025-02-26 11:47 ` [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when auto-negotiation is off Tariq Toukan
2025-02-28 22:51 ` Jakub Kicinski
2025-03-02 8:17 ` Shahar Shitrit
2025-03-03 22:19 ` Jakub Kicinski
2025-02-28 23:54 ` Jakub Kicinski [this message]
2025-02-26 11:47 ` [PATCH net-next 4/6] net/mlx5: Lag, Enable Multiport E-Switch offloads on 8 ports LAG Tariq Toukan
2025-03-04 7:12 ` Michal Swiatkowski
2025-02-26 11:47 ` [PATCH net-next 5/6] net/mlx5e: Separate address related variables to be in struct Tariq Toukan
2025-03-04 7:23 ` Michal Swiatkowski
2025-02-26 11:47 ` [PATCH net-next 6/6] net/mlx5e: Properly match IPsec subnet addresses Tariq Toukan
2025-03-04 7:50 ` Michal Swiatkowski
2025-03-04 8:05 ` Leon Romanovsky
2025-03-04 9:51 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228155437.0a6ec42a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shshitrit@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox