Re: [PATCH rdma-next 1/6] RDMA/uverbs: Introduce UCAP (User CAPabilities) API

[Leon Romanovsky <leon@kernel.org>]

On Tue, Mar 04, 2025 at 10:30:26AM -0400, Jason Gunthorpe wrote:
> On Tue, Mar 04, 2025 at 03:44:18PM +0200, Leon Romanovsky wrote:
> 
> > > > +	device_initialize(&ucap->dev);
> > > > +	ucap->dev.class = &ucaps_class;
> > > > +	ucap->dev.devt = MKDEV(MAJOR(ucaps_base_dev), type);
> > > > +	ucap->dev.release = ucap_dev_release;
> > > > +	dev_set_name(&ucap->dev, ucap_names[type]);
> > > 
> > > Missing error handling on dev_set_name()
> > 
> > Most of the kernel users don't check dev_set_name(). It can't fail in
> > reality.
> 
> I'd still add the missing check

I can add this hunk while applying the patch.

diff --git a/drivers/infiniband/core/ucaps.c b/drivers/infiniband/core/ucaps.c
index 82b1184891ed..e958bd6e34d7 100644
--- a/drivers/infiniband/core/ucaps.c
+++ b/drivers/infiniband/core/ucaps.c
@@ -169,7 +169,9 @@ int ib_create_ucap(enum rdma_user_cap type)
        ucap->dev.class = &ucaps_class;
        ucap->dev.devt = MKDEV(MAJOR(ucaps_base_dev), type);
        ucap->dev.release = ucap_dev_release;
-       dev_set_name(&ucap->dev, ucap_names[type]);
+       ret = dev_set_name(&ucap->dev, ucap_names[type]);
+       if (ret)
+               goto err_device;

        cdev_init(&ucap->cdev, &ucaps_cdev_fops);
        ucap->cdev.owner = THIS_MODULE;



> 
> Jason