From: Jason Gunthorpe <jgg@nvidia.com>
To: Mark Bloch <mbloch@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Arnd Bergmann <arnd@kernel.org>,
Patrisious Haddad <phaddad@nvidia.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/mlx5: Fix compilation warning when USER_ACCESS isn't set
Date: Mon, 7 Apr 2025 15:18:16 -0300 [thread overview]
Message-ID: <20250407181816.GA1769225@nvidia.com> (raw)
In-Reply-To: <20250402070944.1022093-1-mbloch@nvidia.com>
On Wed, Apr 02, 2025 at 10:09:44AM +0300, Mark Bloch wrote:
> The cited commit made fs.c always compile, even when
> INFINIBAND_USER_ACCESS isn't set. This results in a compilation
> warning about an unused object when compiling with W=1 and
> USER_ACCESS is unset.
>
> Fix this by defining uverbs_destroy_def_handler() even when
> USER_ACCESS isn't set.
>
> Fixes: 36e0d433672f ("RDMA/mlx5: Compile fs.c regardless of INFINIBAND_USER_ACCESS config")
> Signed-off-by: Mark Bloch <mbloch@nvidia.com>
> Tested-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/infiniband/hw/mlx5/fs.c | 2 --
> include/rdma/ib_verbs.h | 7 +++++++
> 2 files changed, 7 insertions(+), 2 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2025-04-07 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 7:09 [PATCH rdma-next] RDMA/mlx5: Fix compilation warning when USER_ACCESS isn't set Mark Bloch
2025-04-03 10:08 ` Arnd Bergmann
2025-04-07 18:18 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407181816.GA1769225@nvidia.com \
--to=jgg@nvidia.com \
--cc=arnd@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=phaddad@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).