public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Baris Can Goral <goralbaris@gmail.com>
To: allison.henderson@oracle.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: horms@kernel.org, linux-rdma@vger.kernel.org,
	skhan@linuxfoundation.org, Baris Can Goral <goralbaris@gmail.com>
Subject: [PATCH net-next v2] Replace strncpy with strscpy
Date: Wed,  9 Apr 2025 00:21:23 +0300	[thread overview]
Message-ID: <20250408212122.10517-1-goralbaris@gmail.com> (raw)
In-Reply-To: <20250408182203.GH395307@horms.kernel.org>

The strncpy() function is actively dangerous to use since it may not
NULL-terminate the destination string, resulting in potential memory.
Link: https://github.com/KSPP/linux/issues/90

Signed-off-by: Baris Can Goral <goralbaris@gmail.com>
---
 net/rds/connection.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/rds/connection.c b/net/rds/connection.c
index c749c5525b40..4bb727dd13b0 100644
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -749,8 +749,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp, void *buffer)
 	cinfo->laddr = conn->c_laddr.s6_addr32[3];
 	cinfo->faddr = conn->c_faddr.s6_addr32[3];
 	cinfo->tos = conn->c_tos;
-	strncpy(cinfo->transport, conn->c_trans->t_name,
-		sizeof(cinfo->transport));
+	strscpy(cinfo->transport, conn->c_trans->t_name);
 	cinfo->flags = 0;
 
 	rds_conn_info_set(cinfo->flags, test_bit(RDS_IN_XMIT, &cp->cp_flags),
@@ -775,7 +774,7 @@ static int rds6_conn_info_visitor(struct rds_conn_path *cp, void *buffer)
 	cinfo6->next_rx_seq = cp->cp_next_rx_seq;
 	cinfo6->laddr = conn->c_laddr;
 	cinfo6->faddr = conn->c_faddr;
-	strncpy(cinfo6->transport, conn->c_trans->t_name,
+	strscpy(cinfo6->transport, conn->c_trans->t_name,
 		sizeof(cinfo6->transport));
 	cinfo6->flags = 0;
 
-- 
2.34.1


  reply	other threads:[~2025-04-08 21:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250407183052.8763-1-goralbaris@gmail.com>
2025-04-08 18:22 ` [PATCH] net: rds transform strncpy to strscpy Simon Horman
2025-04-08 21:21   ` Baris Can Goral [this message]
2025-05-17 18:12     ` [PATCH net-next v2] Replace strncpy with strscpy goralbaris
2025-05-18  9:00       ` Simon Horman
2025-05-18 19:53         ` [PATCH v3 net-next: rds] replace strncpy with strscpy_pad goralbaris
2025-05-19  7:01           ` Michal Swiatkowski
2025-05-19 12:51             ` [PATCH v4 " Baris Can Goral
2025-05-19 21:15               ` Allison Henderson
2025-05-20 16:23                 ` [PATCH v5 " Baris Can Goral
2025-05-20 21:13                   ` Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250408212122.10517-1-goralbaris@gmail.com \
    --to=goralbaris@gmail.com \
    --cc=allison.henderson@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox