Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
To: donald.hunter@gmail.com, kuba@kernel.org, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
	vadim.fedorenko@linux.dev, jiri@resnulli.us,
	anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
	andrew+netdev@lunn.ch, saeedm@nvidia.com, leon@kernel.org,
	tariqt@nvidia.com, jonathan.lemon@gmail.com,
	richardcochran@gmail.com, aleksandr.loktionov@intel.com,
	milena.olech@intel.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Subject: [PATCH net-next v2 0/4] dpll: add all inputs phase offset monitor
Date: Tue, 15 Apr 2025 20:15:39 +0200	[thread overview]
Message-ID: <20250415181543.1072342-1-arkadiusz.kubalewski@intel.com> (raw)

Add simple dpll device level feature and capabilties infrastructure over
netlink dpll interface.
Using new infrastructure add new feature: ALL_INPUTS_PHASE_OFFSET_MONITOR.
Allow users control with two new attributes:
- DPLL_A_CAPABILITIES - for checking if dpll device is capable,
- DPLL_A_FEATURES - for enable/disable a features.
Implement feature in ice driver for dpll-enabled devices.

Verify capability:
$ ./tools/net/ynl/pyynl/cli.py \
 --spec Documentation/netlink/specs/dpll.yaml \
 --dump device-get
[{'capabilities': set(),
  'clock-id': 4658613174691613800,
  'features': set(),
  'id': 0,
  'lock-status': 'locked-ho-acq',
  'mode': 'automatic',
  'mode-supported': ['automatic'],
  'module-name': 'ice',
  'type': 'eec'},
 {'capabilities': {'all-inputs-phase-offset-monitor'},
  'clock-id': 4658613174691613800,
  'features': set(),
  'id': 1,
  'lock-status': 'locked-ho-acq',
  'mode': 'automatic',
  'mode-supported': ['automatic'],
  'module-name': 'ice',
  'type': 'pps'}]

Enable the feature:
$ ./tools/net/ynl/pyynl/cli.py \
 --spec Documentation/netlink/specs/dpll.yaml \
 --do device-set --json '{"id":1, \
 "features":"all-inputs-phase-offset-monitor"}'

Verify feature is enabled:
$ ./tools/net/ynl/pyynl/cli.py \
 --spec Documentation/netlink/specs/dpll.yaml \
 --dump device-get
[
 [...]
 {'capabilities': {'all-inputs-phase-offset-monitor'},
  'clock-id': 4658613174691613800,
  'features': {'all-inputs-phase-offset-monitor'},
  'id': 1,
 [...]
]

Disable the feature:
$ ./tools/net/ynl/pyynl/cli.py \
 --spec Documentation/netlink/specs/dpll.yaml \
 --do device-set --json '{"id":1, \
 "features":0}'


Arkadiusz Kubalewski (4):
  dpll: use struct dpll_device_info for dpll registration
  dpll: add features and capabilities to dpll device spec
  dpll: features_get/set callbacks
  ice: add phase offset monitor for all PPS dpll inputs

 Documentation/netlink/specs/dpll.yaml         |  25 +++
 drivers/dpll/dpll_core.c                      |  34 +--
 drivers/dpll/dpll_core.h                      |   2 +-
 drivers/dpll/dpll_netlink.c                   |  86 +++++++-
 drivers/dpll/dpll_nl.c                        |   5 +-
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  20 ++
 drivers/net/ethernet/intel/ice/ice_common.c   |  26 +++
 drivers/net/ethernet/intel/ice/ice_common.h   |   3 +
 drivers/net/ethernet/intel/ice/ice_dpll.c     | 195 +++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_dpll.h     |   7 +
 drivers/net/ethernet/intel/ice/ice_main.c     |   4 +
 .../net/ethernet/mellanox/mlx5/core/dpll.c    |  10 +-
 drivers/ptp/ptp_ocp.c                         |   7 +-
 include/linux/dpll.h                          |  16 +-
 include/uapi/linux/dpll.h                     |  13 ++
 15 files changed, 417 insertions(+), 36 deletions(-)


base-commit: bbfc077d457272bcea4f14b3a28247ade99b196d
-- 
2.38.1


             reply	other threads:[~2025-04-15 18:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 18:15 Arkadiusz Kubalewski [this message]
2025-04-15 18:15 ` [PATCH net-next v2 1/4] dpll: use struct dpll_device_info for dpll registration Arkadiusz Kubalewski
2025-04-16 12:13   ` Jiri Pirko
2025-04-17  9:33     ` Kubalewski, Arkadiusz
2025-04-17  9:56       ` Jiri Pirko
2025-04-17  2:09   ` Jakub Kicinski
2025-04-17  9:34     ` Kubalewski, Arkadiusz
2025-04-15 18:15 ` [PATCH net-next v2 2/4] dpll: add features and capabilities to dpll device spec Arkadiusz Kubalewski
2025-04-15 18:15 ` [PATCH net-next v2 3/4] dpll: features_get/set callbacks Arkadiusz Kubalewski
2025-04-16 12:10   ` Jiri Pirko
2025-04-17  9:23     ` Kubalewski, Arkadiusz
2025-04-17  9:59       ` Jiri Pirko
2025-05-08 12:30         ` Kubalewski, Arkadiusz
2025-04-15 18:15 ` [PATCH net-next v2 4/4] ice: add phase offset monitor for all PPS dpll inputs Arkadiusz Kubalewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250415181543.1072342-1-arkadiusz.kubalewski@intel.com \
    --to=arkadiusz.kubalewski@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jiri@resnulli.us \
    --cc=jonathan.lemon@gmail.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=milena.olech@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=richardcochran@gmail.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox