From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BDEA3D76; Mon, 26 May 2025 05:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237420; cv=none; b=UBjviH/2rUI/ypwS4Zqv+LRsiIiUuhuTSZRENXQsacH29o91V7NBCDfaKRViXYRPKmkRXjP+RCvKHwNAl67EdOZ8L+3ZlJjqnJr9vDU5O+EU/A7+y2lnsTKgjl84McDuWeFB4zezOTQoytceuxRTTGx9P1BiupcyVRocwyrKk9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237420; c=relaxed/simple; bh=ihB9kmsFYOTM4O+AIj/y7KMLQmIWQpp0Qy5KMfBICrE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=niRVW3lpLiEeWvLfVeErand1VFBeJrdSjP4nPJ45+RvvpKE5eh8VrCu+XxKY0fR+dPMcoIOeF08MPYm4DtR+bTQbAExaEpdfBahrQUmNHR1TsS41p9fhTyFmWSVJpyrZMuudYeG10ieCgfZgsFskCSiY7MUFLjdJYTWC36/zX0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 35E6F68D0D; Mon, 26 May 2025 07:30:14 +0200 (CEST) Date: Mon, 26 May 2025 07:30:13 +0200 From: Christoph Hellwig To: Kuniyuki Iwashima Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , Simon Horman , Kuniyuki Iwashima , Chuck Lever , Jeff Layton , Matthieu Baerts , Keith Busch , Jens Axboe , Christoph Hellwig , Wenjia Zhang , Jan Karcher , Steve French , netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v2 net-next 2/7] socket: Rename sock_create_kern() to __sock_create_kern(). Message-ID: <20250526053013.GC11639@lst.de> References: <20250523182128.59346-1-kuniyu@amazon.com> <20250523182128.59346-3-kuniyu@amazon.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250523182128.59346-3-kuniyu@amazon.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, May 23, 2025 at 11:21:08AM -0700, Kuniyuki Iwashima wrote: > Let's rename sock_create_kern() to __sock_create_kern() as a special > API and add a fat documentation. > > The next patch will add sock_create_kern() that holds netns refcnt. Maybe do this before patch 1 to reduce the churn of just touching a lot of the same callers again?