Re: [RFC v4 02/18] netmem: introduce netmem alloc APIs to wrap page alloc APIs

Suren Baghdasaryan
2025-06-04T15:14:30Z

On Tue, Jun 3, 2025 at 7:53 PM Byungchul Park <byungchul@sk.com> wrote:
>
> To eliminate the use of struct page in page pool, the page pool code
> should use netmem descriptor and APIs instead.
>
> As part of the work, introduce netmem alloc APIs allowing the code to
> use them rather than the existing APIs for struct page.
>
> Signed-off-by: Byungchul Park <byungchul@sk.com>
> ---
> net/core/netmem_priv.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/net/core/netmem_priv.h b/net/core/netmem_priv.h
> index cd95394399b4..32e390908bb2 100644
> --- a/net/core/netmem_priv.h
> +++ b/net/core/netmem_priv.h
> @@ -59,4 +59,18 @@ static inline void netmem_set_dma_index(netmem_ref netmem,
> magic = netmem_get_pp_magic(netmem) | (id << PP_DMA_INDEX_SHIFT);
> __netmem_clear_lsb(netmem)->pp_magic = magic;
> }
> +
> +static inline netmem_ref alloc_netmems_node(int nid, gfp_t gfp_mask,
> + unsigned int order)
> +{
> + return page_to_netmem(alloc_pages_node(nid, gfp_mask, order));
> +}
> +
> +static inline unsigned long alloc_netmems_bulk_node(gfp_t gfp, int nid,
> + unsigned long nr_netmems,
> + netmem_ref *netmem_array)
> +{
> + return alloc_pages_bulk_node(gfp, nid, nr_netmems,
> + (struct page **)netmem_array);
> +}

Note: if you want these allocations to be reported in a separate line
inside /proc/allocinfo you need to use alloc_hooks() like this:

static inline unsigned long alloc_netmems_bulk_node_noprof(gfp_t gfp, int nid,
unsigned long nr_netmems,
netmem_ref *netmem_array)
{
return alloc_pages_bulk_node_noprof((gfp, nid, nr_netmems,
(struct page **)netmem_array);
}

#define alloc_netmems_bulk_node(...) \
alloc_hooks(alloc_netmems_bulk_node_noprof(__VA_ARGS__))

> #endif
> --
> 2.17.1
>