Re: [RFC v4 18/18] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp()

Pavel Begunkov
2025-06-05T13:27:07Z

On 6/5/25 13:17, Harry Yoo wrote:
> On Thu, Jun 05, 2025 at 08:49:07PM +0900, Harry Yoo wrote:
>> On Thu, Jun 05, 2025 at 11:56:14AM +0100, Pavel Begunkov wrote:
>>> On 6/4/25 03:52, Byungchul Park wrote:
>>>> To simplify struct page, the effort to separate its own descriptor from
>>>> struct page is required and the work for page pool is on going.
>>>>
>>>> To achieve that, all the code should avoid directly accessing page pool
>>>> members of struct page.
>>>
>>> Just to clarify, are we leaving the corresponding struct page fields
>>> for now until the final memdesc conversion is done?
>>
>> Yes, that's correct.
>
> Oops, looks like misread it. If by "leaving the corresponding struct page
> fields" you meant "leaving netmem fields in struct page", no.
> It'll be removed.

I see, in which case instead we might want to leave a reminder
in page_pool_page_is_pp in a form of a build warning, but the
patch looks fine either way.

--
Pavel Begunkov